-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace shell.nix
with Nix Flake
#1154
Conversation
Peter -- you're more qualified than me on this stuff, so I just went ahead and invited you to the hackage team so you should be able to merge prs on this repo. Please only do so unilaterally with safe-ish build/nix stuff :-) |
Great, thanks, understood |
c3312b0
to
b3ea4df
Compare
Please review part of this PR, deletion of Basic Auth: #1165 |
Trying to fix the DocTests error: input-output-hk/haskell.nix#1829 |
hackage-server.cabal
Outdated
@@ -647,5 +647,5 @@ test-suite DocTests | |||
main-is: DocTestMain.hs | |||
build-depends: | |||
, lib-server | |||
, doctest-parallel ^>= 0.2.2 | |||
, doctest-parallel >= 0.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any justification for this new lower bound? (Add to the comment below it.)
I suppose it should also be given an upper bound.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running the DocTests in the Flake currently has an error. I'm not sure yet if the error is in haskell.nix
, doctest-parallel
, or some other place
Investigating
input-output-hk/haskell.nix#1829
martijnbastiaan/doctest-parallel#66
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replacing ghc
with ghc-lib
in doctests-parallel
produces a different error, but I think it may be a step in the right direction
aaf24c8
to
1df3d4a
Compare
the `flake.nix` build fails on these warnings: haskell#1154
cfbecdb
to
24b1e75
Compare
about Lines 13 to 22 in 24b1e75
|
24b1e75
to
1976142
Compare
the `flake.nix` build fails on these warnings: haskell#1154
1976142
to
af52f0d
Compare
* fix `incomplete-uni-patterns` warning, ignore some others the `flake.nix` build fails on these warnings: #1154 * ignore `incomplete-uni-patterns` warning
@peterbecich , FYI:
|
the `flake.nix` build fails on these warnings: haskell#1154
5dfe77d
to
a5ffb70
Compare
We can also try using https://github.com/srid/haskell-flake instead of |
Ah, yes, I was suprised that I had to add
hackage-server/src/Distribution/Server/Features/UserSignup.hs Lines 437 to 441 in 08d61eb
|
the `flake.nix` build fails on these warnings: haskell#1154
Squashed commit of the following: commit fae5c89 Author: Peter Becich <[email protected]> Date: Sun Mar 12 21:43:23 2023 -0700 `nix develop` and `nix build` work commit 9c3d54e Author: Peter Becich <[email protected]> Date: Sun Mar 5 13:24:29 2023 -0800 use https://github.com/srid/haskell-flake commit a56bcee Author: Peter Becich <[email protected]> Date: Fri Mar 3 22:21:27 2023 -0800 update sources commit b013302 Author: Peter Becich <[email protected]> Date: Tue Feb 28 18:06:28 2023 -0800 update Cabal in both NixPkgs and hackage.nix commit aaff29c Author: Peter Becich <[email protected]> Date: Mon Feb 27 18:55:48 2023 -0800 attempt to fix `doctest-parallel` by updating Cabal input-output-hk/haskell.nix#1829 commit ccc9ced Author: Peter Becich <[email protected]> Date: Sun Feb 26 23:16:28 2023 -0800 investigate `gd` build error in `nix develop` shell input-output-hk/haskell.nix#1865 commit efd9de5 Author: Peter Becich <[email protected]> Date: Sun Feb 26 01:49:08 2023 -0800 more dependencies commit fb94055 Author: Peter Becich <[email protected]> Date: Sun Feb 26 01:19:33 2023 -0800 work on `develop` shell commit 495a54e Author: Peter Becich <[email protected]> Date: Sat Feb 4 16:28:05 2023 -0800 replace `shell.nix` with `haskell.nix` Flake commit e0e8f41 Author: Peter Becich <[email protected]> Date: Sun Feb 5 17:56:04 2023 -0800 ignore `incomplete-uni-patterns` warning commit e4747e9 Author: Peter Becich <[email protected]> Date: Sat Feb 4 15:31:06 2023 -0800 fix `incomplete-uni-patterns` warning, ignore some others the `flake.nix` build fails on these warnings: haskell#1154
I think this will speed up the CI build time (#1078) plus other benefits
TODO
x86_64-darwin
oraarch64-darwin
LegacyPasswd
code and dependency oncrypt
#1153nix flake check
doctest-parallel
error input-output-hk/haskell.nix#1829