Fix --offline flag (backport #8676) #8838
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* WIP * WIP * WIP * WIP * WIP * add offline logic branch * Clean up * Formatting * Optimize * Rename test folder * Add changelog file * Fix whitespace * Add <CABAL_ERROR> normalizer tag * code review changes * Delet vs code file * Fix import * fix wrong output file --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 0ed1218)
| @@ -559,6 +562,7 @@ invalidatePackageRegFileMonitor PackageFileMonitor{pkgFileMonitorReg} = | |||
| -- It requires the 'BuildStatusMap' gathered by 'rebuildTargetsDryRun'. | |||
| -- | |||
| rebuildTargets :: Verbosity | |||
| -> ProjectConfig | |||
There was a problem hiding this comment.
This is a breaking change since rebuildTargets is exported https://hackage.haskell.org/package/cabal-install-3.8.1.0/docs/Distribution-Client-ProjectBuilding.html#v:rebuildTargets
| @@ -192,6 +192,7 @@ instance Exception BuildFailure | |||
| -- | Detail on the reason that a package failed to build. | |||
| -- | |||
| data BuildFailureReason = DependentFailed PackageId | |||
| | GracefulFailure String | |||
There was a problem hiding this comment.
Same as above, BuildFailureReason is exported. https://hackage.haskell.org/package/cabal-install-3.8.1.0/docs/Distribution-Client-ProjectBuilding-Types.html#t:BuildFailureReason
|
I am confused, is this a backport ... into 3.10? In that case, apologies, and please ignore my comments 🙃 |
|
@andreabedini good point about breaking changes. Initially I treated this as a bug fix, but your observation means we can't release it in 3.10.2, so i guess we should close it? |
|
I remember a discussion that cabal-install and cabal-install-solver are implicitly under |
|
If nobody in the user base is aware of such a contract it's not going to go very far indeed |
1 similar comment
|
If nobody in the user base is aware of such a contract it's not going to go very far indeed |
|
Yeah so 3.10.1.0 has been released with BuildFailureReason We cannot add a new constructor to it without a major version bump (i.e. 3.11). Same applied to
What would be the rationale for this? |
|
@andreabedini I'm totally on board with not backporting, and again thank you for catching it. Mikolaj should do the final call though. |
|
I must have hallucinated the |
This is an automatic backport of pull request #8676 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com