-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: add GHC pre-release #8754
Merged
Merged
CI: add GHC pre-release #8754
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
CI: add validation against GHC pre-release (currently: 9.6alpha3)
Had to block lib/cli-suite tests on Windows, see discussion starting here: - #8754 (comment)
- test-tag-of-gitlab-ci-2
- test-tag-of-gitlab-ci
- cabal-install-v3.14.1.1
- cabal-install-v3.14.1.0
- cabal-install-v3.12.1.0
- cabal-install-v3.12.0.0-prerelease
- cabal-install-solver-v3.14.1.0
- cabal-install-solver-v3.12.1.0
- cabal-head
- Cabal-v3.14.1.1
- Cabal-v3.14.1.0
- Cabal-v3.12.1.0
- Cabal-v3.12.0.0
- Cabal-syntax-v3.14.1.0
- Cabal-syntax-v3.12.1.0
- Cabal-syntax-v3.12.0.0
- Cabal-syntax-3.14.0.0
- Cabal-hooks-3.14.1.1
- Cabal-3.14.0.0
- 3.12.1+0
- 3.12.0+0
commit 9e9a8658b245aa4baf8983bbeab656a6e4692213
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think each of these should come with a
installed
constraint:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the
Cabal*
libraries? They're certainly not installed? I must confess, i don't really understand theinstalled
constraint. It makes me think ofcabal v1-install
which is certainly not the same, but I otherwise fail to see where it isinstalled
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about it more: I really don't see why you'd want to maintain an additional list (a list of constraints on top of the list in allow-newer)...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the GHC-shipped packets are installed. I guessed you want to pin to the GHC-installed versions in general. But you are right, not for the Cabal packages.
The reason for pinning the GHC-shipped packages is that you want to e.g. make sure that
unix-2.8.0.0
is picked and not some older version. But I guess thatbase
,ghc-prim
andtemplate-haskell
are pinned anyway. And you did not includeallow-newer
for the other GHC-shipped packages.So I retract my suggestion.
You could consider to pin all the other GHC-shipped packages, though, and add
allow-newer
for them, if you truly want to test against the coming GHC-shipped libraries.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right, thank you for the clarification. Let's leave it for future work: most likely, this code will need updates every prerelease...