Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add GHC pre-release #8754

Merged
merged 3 commits into from
Feb 23, 2023
Merged

CI: add GHC pre-release #8754

merged 3 commits into from
Feb 23, 2023

Conversation

ulysses4ever
Copy link
Collaborator

@ulysses4ever ulysses4ever commented Feb 11, 2023

Currently: 9.6alpha3. Corresponding issue #8675.

This is more of an experiment for now.

@ulysses4ever ulysses4ever marked this pull request as draft February 11, 2023 17:21
@ulysses4ever ulysses4ever force-pushed the ci-9.6 branch 7 times, most recently from 4e682e2 to 398f339 Compare February 12, 2023 03:24
@ulysses4ever
Copy link
Collaborator Author

Current error I'm getting: it's trying to build Cabal-syntax-3.8.0.0 for some reason. I tried to add constraints: Cabal-syntax ==3.9.0.0 but it didn't seem to have any effect...

@Mikolaj
Copy link
Member

Mikolaj commented Feb 13, 2023

I can't see cabal.project.validate used anywhere.

@Mikolaj
Copy link
Member

Mikolaj commented Feb 13, 2023

Oh, never mind, it is. :)

@Mikolaj
Copy link
Member

Mikolaj commented Feb 13, 2023

Re "trying to build Cabal-syntax-3.8.0.0" is that in the place where it insists on using "last stable cabal" for testing due to mysterious reasons?

@ulysses4ever
Copy link
Collaborator Author

@Mikolaj good guess. Here's the run just in case. That issue arises when we update Cabal, I think. In this PR Cabal does not change (only GHC does), so I'm not sure this is it.

@Mikolaj
Copy link
Member

Mikolaj commented Feb 14, 2023

So the guess is smart, but does not match reality? :)

It says in the build log that it's going to build "Cabal-3.9.0.0" and " cabal-install-3.9.0.0" and "Cabal-3.8.1.0". So perhaps a tool requires the old Cabal? But it's not https://github.com/haskell/hackage-security/blob/master/hackage-security/hackage-security.cabal, because 3.9 is fine for it. (BTW, I have to update it ASAP).

@Mikolaj
Copy link
Member

Mikolaj commented Feb 14, 2023

Perhaps -v2 would tell us what requires the old cabal?

@ulysses4ever
Copy link
Collaborator Author

I pushed -v2 but I suspect we'd rather need to stare at cabal-plan output.

@Mikolaj
Copy link
Member

Mikolaj commented Feb 15, 2023

It probably doesn't like the space between v and 2.

@ulysses4ever
Copy link
Collaborator Author

@Mikolaj I tried without the space first, and it failed just as well... I'll need to look how validate.sh works

@ulysses4ever
Copy link
Collaborator Author

validate.sh doesn't take -vN — only -v. But the problem seems to be solved by allowing newer everything. In the previous iteration I only allowed newer versions of few boot libraries. Seems like somehow Cabal/-syntax ended up limited by that. I could try to explicitly allow newer it, perhaps, but I'm a bit tired of hunting just the right set of relaxations: it seems counterproductive when the wildcard Just Works™.

@ulysses4ever ulysses4ever force-pushed the ci-9.6 branch 2 times, most recently from 23404e6 to 99522c8 Compare February 16, 2023 03:19
@ulysses4ever
Copy link
Collaborator Author

Hmm, the current failure I don't understand.

@Mikolaj
Copy link
Member

Mikolaj commented Feb 16, 2023

How about running with Wno-error=unused-imports? I guess some export lists changed in a backward-compatible way except that some import my not be needed now.

@ulysses4ever
Copy link
Collaborator Author

ulysses4ever commented Feb 16, 2023

@Mikolaj I could try but can you explain how you arrived at this guses? I don't see any meaningful error message at all!

@ulysses4ever
Copy link
Collaborator Author

Sorry, my autocorrection is obnoxious. Edited.

@Mikolaj
Copy link
Member

Mikolaj commented Feb 16, 2023

@ulysses4ever: I found this line: https://github.com/haskell/cabal/actions/runs/4190364961/jobs/7263697303#step:14:4304

Is it relevant?

@ulysses4ever
Copy link
Collaborator Author

Oh, so it's buried deep under…That's sad!

So, this is a result of haskell/core-libraries-committee#50, and #8223 somehow missed it, I wonder how (/cc @googleson78).

I think we shouldn't fiddle with warning flags but rather apply the standard fix (see #8223).

@ulysses4ever
Copy link
Collaborator Author

ulysses4ever commented Feb 16, 2023

The CPP stuff is way over my head, unfortunately. If someone knows exactly how to deal with just import Control.Applicative (lift2A), don't be shy -- share! Probably good.

@Mikolaj
Copy link
Member

Mikolaj commented Feb 23, 2023

Let's fast-merge this and then backport, so that we still have a moment to tweak anything this CI extension uncovers, before the release.

@ulysses4ever
Copy link
Collaborator Author

@Mikolaj agreed. I'll apply merge-delay-passed label then.

@ulysses4ever ulysses4ever added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Feb 23, 2023
- -XTypeInType is deprecated
- skip failing JS test on Windows
  Cf. haskell#8754 (comment)
- deal with lift2A in Prelude since base-4.18 (GHC 9.6)
- disable everfailing Backpack tests
Had to block lib/cli-suite tests on Windows, see discussion starting here:

- haskell#8754 (comment)
@mergify mergify bot merged commit 0eb638f into haskell:master Feb 23, 2023
mergify bot pushed a commit that referenced this pull request Feb 23, 2023
- -XTypeInType is deprecated
- skip failing JS test on Windows
  Cf. #8754 (comment)
- deal with lift2A in Prelude since base-4.18 (GHC 9.6)
- disable everfailing Backpack tests

(cherry picked from commit 87ac120)
mergify bot pushed a commit that referenced this pull request Feb 23, 2023
Had to block lib/cli-suite tests on Windows, see discussion starting here:

- #8754 (comment)

(cherry picked from commit 9e9a865)
@Mikolaj
Copy link
Member

Mikolaj commented Feb 24, 2023

@mergify backport 3.10

@mergify
Copy link
Contributor

mergify bot commented Feb 24, 2023

backport 3.10

✅ Backports have been created

@Mikolaj
Copy link
Member

Mikolaj commented Feb 24, 2023

@mergify backport temporary-3.10-to-fix-a-backport

@mergify
Copy link
Contributor

mergify bot commented Feb 24, 2023

backport temporary-3.10-to-fix-a-backport

❌ No backport have been created

  • Backport to branch temporary-3.10-to-fix-a-backport failed

GitHub error: Branch not found

@Mikolaj
Copy link
Member

Mikolaj commented Feb 24, 2023

@mergify backport temporary-3.10-to-fix-a-backport

@mergify
Copy link
Contributor

mergify bot commented Feb 24, 2023

backport temporary-3.10-to-fix-a-backport

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 24, 2023
- -XTypeInType is deprecated
- skip failing JS test on Windows
  Cf. #8754 (comment)
- deal with lift2A in Prelude since base-4.18 (GHC 9.6)
- disable everfailing Backpack tests

(cherry picked from commit 87ac120)
mergify bot pushed a commit that referenced this pull request Feb 24, 2023
Had to block lib/cli-suite tests on Windows, see discussion starting here:

- #8754 (comment)

(cherry picked from commit 9e9a865)
Mikolaj added a commit that referenced this pull request Feb 24, 2023
…x-a-backport/pr-8754

CI: add GHC pre-release (backport #8754)
mergify bot pushed a commit that referenced this pull request Feb 24, 2023
- -XTypeInType is deprecated
- skip failing JS test on Windows
  Cf. #8754 (comment)
- deal with lift2A in Prelude since base-4.18 (GHC 9.6)
- disable everfailing Backpack tests

(cherry picked from commit 87ac120)
(cherry picked from commit 8f08602)
mergify bot pushed a commit that referenced this pull request Feb 24, 2023
Had to block lib/cli-suite tests on Windows, see discussion starting here:

- #8754 (comment)

(cherry picked from commit 9e9a865)
(cherry picked from commit 8dc3221)
mergify bot added a commit that referenced this pull request Feb 24, 2023
CI: add GHC pre-release (backport #8754) (backport #8805)
@ulysses4ever ulysses4ever mentioned this pull request Mar 15, 2023
15 tasks
@ulysses4ever ulysses4ever deleted the ci-9.6 branch April 21, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous-integration merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge re: ghc 9.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants