Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cabal init should not suggest Cabal < 2.0 #8700

Merged
merged 2 commits into from
Jan 29, 2023
Merged

Fix cabal init should not suggest Cabal < 2.0 #8700

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6225b8
Fix cabal init should not suggest Cabal < 2.0
BasLaa Jan 25, 2023
1606cde
Remove + symbol cabal-version 2.0
BasLaa Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cabal-install/src/Distribution/Client/Init/Interactive/Command.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,6 @@ cabalVersionPrompt flags = getCabalVersion flags $ do

displayCabalVersion :: CabalSpecVersion -> String
displayCabalVersion v = case v of
CabalSpecV1_24 -> "1.24 (legacy)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this removal, '+' on the next line doesn't make sense, probably.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, How can I cancel checks that are in progress? Under Actions -> workflow I can't seem to find a cancel button.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I cancel checks that are in progress?

Don't worry. However, I've just invited you to Triage the repo, so there's a small chance you can see the cancel buttons now (but remember to never mouse over the big red button!).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that. I believe this solves issue #8680. I also added a changelog file as it was stated in the contribution guide.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I was wondering about; I ran the test suite locally on my computer, and I got that a test failed, whereas here everything passes. Is there a known reason for that?

Copy link
Collaborator

@ulysses4ever ulysses4ever Jan 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely used to have tests failing locally and succeeding in CI. I think one reason may be that some system dependencies may be absent on your machine. It's not nice but it's probably fine.

CabalSpecV2_0 -> "2.0 (+ support for Backpack, internal sub-libs, '^>=' operator)"
CabalSpecV2_2 -> "2.2 (+ support for 'common', 'elif', redundant commas, SPDX)"
CabalSpecV2_4 -> "2.4 (+ support for '**' globbing)"
Expand Down
9 changes: 9 additions & 0 deletions changelog.d/issue-8680
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
synopsis: cabal init should not suggest Cabal < 2.0
packages: Cabal
issues: #8680

description: {

'cabal init' no longer suggests users to set cabal-version to less than 2.0

}