Fix cabal init should not suggest Cabal < 2.0 #8700
Conversation
| @@ -286,7 +286,6 @@ cabalVersionPrompt flags = getCabalVersion flags $ do | |||
|
|
|||
| displayCabalVersion :: CabalSpecVersion -> String | |||
| displayCabalVersion v = case v of | |||
| CabalSpecV1_24 -> "1.24 (legacy)" | |||
There was a problem hiding this comment.
After this removal, '+' on the next line doesn't make sense, probably.
There was a problem hiding this comment.
Good point, How can I cancel checks that are in progress? Under Actions -> workflow I can't seem to find a cancel button.
There was a problem hiding this comment.
How can I cancel checks that are in progress?
Don't worry. However, I've just invited you to Triage the repo, so there's a small chance you can see the cancel buttons now (but remember to never mouse over the big red button!).
There was a problem hiding this comment.
Thank you for that. I believe this solves issue #8680. I also added a changelog file as it was stated in the contribution guide.
There was a problem hiding this comment.
One thing I was wondering about; I ran the test suite locally on my computer, and I got that a test failed, whereas here everything passes. Is there a known reason for that?
There was a problem hiding this comment.
I definitely used to have tests failing locally and succeeding in CI. I think one reason may be that some system dependencies may be absent on your machine. It's not nice but it's probably fine.
|
Is there anything I need to do for this PR now, or just wait for approving reviews? |
|
@BasLaa thanks! Should be merged in two days automatically if no other comments are received. |
mergify
bot
added
the
merge delay passed
Any Cabal release prior to 2.0 is no longer working, so cabal should not suggest users to set the
cabal-versionon packages to less than 2.0 as mentioned in #8680.With this, the least choice offered to users is 2.0.