Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't create a cache directory when the compiler isn't configured #8627

Merged
merged 4 commits into from
Jan 4, 2023

Conversation

gbaz
Copy link
Collaborator

@gbaz gbaz commented Dec 6, 2022

Resolves #8550
Resolves #8589

This is almost the same fix as #8358 but that didn't go quite far enough -- it deferred the check, but not the cache directory creation for the check.

Refs:

@Mikolaj
Copy link
Member

Mikolaj commented Dec 7, 2022

@mergify rebase

@mergify
Copy link
Contributor

mergify bot commented Dec 7, 2022

rebase

✅ Branch has been successfully rebased

@gbaz gbaz force-pushed the gb/no-create-unnecessary-cache branch from 896b22b to 5a635d7 Compare December 7, 2022 10:10
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no way to write a test for this I presume?

@Mikolaj
Copy link
Member

Mikolaj commented Jan 2, 2023

@gbaz: would you mind adding this PR number to the changelog file for the previous PR?

@gbaz gbaz added the squash+merge me Tell Mergify Bot to squash-merge label Jan 2, 2023
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Jan 4, 2023
@mergify mergify bot merged commit d165b30 into master Jan 4, 2023
@ulysses4ever
Copy link
Collaborator

ulysses4ever commented Jan 4, 2023

There are talks about another 3.8 release. Should this one be backported to 3.8? I say: yes. Regardless of a release, backports are cheap, and this looks like a bugfix to me. Any thoughts?

@andreasabel
Copy link
Member

@ulysses4ever wrote:

There are talks about another 3.8 release.

Yes, but this hasn't been decided yet, and there is no designated individual who would drive it.
The question is when backports should happen. I'd say they should happen only once it is decided that a release will happen.
I'd say a released branch (like 3.8.) should be kept release-ready, so that one can quickly publish a patched version. Release-readiness would mean that only blessed and tested changes are on the branch, and that CI is up and running. The latter seems unfortunately not the case atm. Maybe first the CI changes have to be backported to 3.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention: needs-test merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days squash+merge me Tell Mergify Bot to squash-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cabal update creates dist-newstyle folder in $PWD cabal repl -b ... generates dist-newstyle
6 participants