-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't create a cache directory when the compiler isn't configured #8627
Conversation
@mergify rebase |
✅ Branch has been successfully rebased |
896b22b
to
5a635d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, no way to write a test for this I presume?
@gbaz: would you mind adding this PR number to the changelog file for the previous PR? |
There are talks about another 3.8 release. Should this one be backported to 3.8? I say: yes. Regardless of a release, backports are cheap, and this looks like a bugfix to me. Any thoughts? |
@ulysses4ever wrote:
Yes, but this hasn't been decided yet, and there is no designated individual who would drive it. |
Resolves #8550
Resolves #8589
This is almost the same fix as #8358 but that didn't go quite far enough -- it deferred the check, but not the cache directory creation for the check.
Refs:
cabal repl -b ...
generatesdist-newstyle
#8550