don't create a cache directory when the compiler isn't configured (#8627

) * don't create a cache directory when the compiler isn't configured * Update pr-8358 Co-authored-by: Gershom Bazerman <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
haskell · Jan 4, 2023 · d165b30 · d165b30
1 parent 6467407
commit d165b30
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/cabal-install/src/Distribution/Client/ProjectPlanning.hs b/cabal-install/src/Distribution/Client/ProjectPlanning.hs
@@ -332,10 +332,10 @@ rebuildProjectConfig verbosity
                        fileMonitorProjectConfigKey -- todo check deps too?
       $ do
           liftIO $ info verbosity "Project settings changed, reconfiguring..."
-          liftIO $ createDirectoryIfMissingVerbose verbosity True distProjectCacheDirectory
           projectConfigSkeleton <- phaseReadProjectConfig
-          -- have to create the cache directory before configuring the compiler
           let fetchCompiler = do
+                 -- have to create the cache directory before configuring the compiler
+                 liftIO $ createDirectoryIfMissingVerbose verbosity True distProjectCacheDirectory
                  (compiler, Platform arch os, _) <- configureCompiler verbosity distDirLayout ((fst $ PD.ignoreConditions projectConfigSkeleton) <> cliConfig)
                  pure (os, arch, compilerInfo compiler)
 

diff --git a/changelog.d/pr-8358 b/changelog.d/pr-8358
@@ -1,7 +1,7 @@
 synopsis: Update and sdist now only check for compiler when project file has conditionals
 packages: cabal-install
-prs: #8358
-issues: #8352
+prs: #8358 #8627
+issues: #8352 #8550 #8589
 
 description: {