Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention password-command option in upload --help #6609

Closed
wants to merge 1 commit into from
Closed

Mention password-command option in upload --help #6609

wants to merge 1 commit into from

Conversation

v0d1ch
Copy link
Contributor

@v0d1ch v0d1ch commented Mar 23, 2020

No description provided.

phadej
phadej suggested changes Mar 23, 2020
View reviewed changes
Copy link
Collaborator

@phadej phadej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the commit message.

Should, why?

@v0d1ch
Copy link
Contributor Author

v0d1ch commented Mar 23, 2020

I copy pasted the issue title there. I can update it if you want. I didn't bother in the first place since the change is very trivial.

@phadej
Copy link
Collaborator

phadej commented Mar 23, 2020

The commit message should explain why the change is made. I don't understand it. Neither there is reference to the issue.

@v0d1ch v0d1ch force-pushed the 5224-cabal-config-should-have-field-for-password-command branch from 9028661 to eff17be Compare March 23, 2020 22:24
@v0d1ch
Copy link
Contributor Author

v0d1ch commented Mar 23, 2020 •
edited
Loading

Oh I just realized this work has already been done here #6313.
What I don't know is why the pr was closed if the changes didn't go in?
It was a long day and I was sloppy. I amended the commit with the changelog too in case we still need this.

@v0d1ch v0d1ch changed the title cabal.config should have a field for password-command Mention password-command option in upload --help Mar 23, 2020
@v0d1ch v0d1ch force-pushed the 5224-cabal-config-should-have-field-for-password-command branch from eff17be to 9d621a6 Compare March 23, 2020 22:26
@v0d1ch v0d1ch force-pushed the 5224-cabal-config-should-have-field-for-password-command branch from 9d621a6 to c78ab2d Compare April 6, 2020 19:40
@v0d1ch
Copy link
Contributor Author

v0d1ch commented Apr 6, 2020

@phadej should we close this one?

@v0d1ch v0d1ch requested a review from phadej April 7, 2020 14:44
@phadej
Copy link
Collaborator

phadej commented Apr 7, 2020

We should merge this, but I still need to check something. Sorry for forgetting this one for a while.

@phadej phadej self-assigned this Apr 9, 2020
@phadej phadej mentioned this pull request Apr 9, 2020
Merged
@phadej
Copy link
Collaborator

phadej commented Apr 20, 2020

Merged in #6680

@phadej phadej closed this Apr 20, 2020
@phadej phadej mentioned this pull request Jul 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phadej phadej Awaiting requested review from phadej

Assignees

@phadej phadej

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v0d1ch @phadej