Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention "password-command" as a config file option #6313

Conversation

dwijnand
Copy link
Contributor

@dwijnand dwijnand commented Oct 27, 2019

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Fixes #5224

I tested this by building cabal-install and looking at the output of upload --help. On it's own, I'm not sure if that's worth wiring up a test for. Perhaps the output of upload --help as a whole could be tested? WDYT?

@hvr
Copy link
Member

hvr commented Nov 2, 2019

@dwijnand tbh, I think it's overkill to add a test for such a trival UI aspect; however, a brief mention in cabal-install's changelog pointing to #5224 would be desirable

@dwijnand dwijnand force-pushed the mention-password-command-as-a-config-file-option branch from 5130a5c to c10808f Compare November 2, 2019 08:21
@dwijnand dwijnand closed this Nov 22, 2019
@dwijnand dwijnand deleted the mention-password-command-as-a-config-file-option branch November 22, 2019 16:30
@phadej phadej mentioned this pull request Jul 10, 2020
@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cabal.config should have a field for password-command.
3 participants