Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include component name in unit-id #6547

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Feb 19, 2020

Only on non-Windows and non-macOS. The unit-ids become a bit longer:

Changes e.g.

component cabal-fmt-0.1.2-ff4d3d1e89ec09722d5bccbf9724beeddb2bd9dcd99a200ff350860e49ecb0f2
    include cabal-fmt-0.1.2-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1
unit cabal-fmt-0.1.2-ff4d3d1e89ec09722d5bccbf9724beeddb2bd9dcd99a200ff350860e49ecb0f2
    include cabal-fmt-0.1.2-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1

to

component cabal-fmt-0.1.2-e-cabal-fmt-173382ac142508c938885649c3384b3512c441f46ff13c57cda2f345fe5f0859
    include cabal-fmt-0.1.2-l-cabal-fmt-internal-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1
unit cabal-fmt-0.1.2-e-cabal-fmt-173382ac142508c938885649c3384b3512c441f46ff13c57cda2f345fe5f0859
    include cabal-fmt-0.1.2-l-cabal-fmt-internal-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1

Resolves #6485


Downside is that this trashes current store :)

@phadej phadej force-pushed the issue-6485-unit-id-internal-lib branch from bb2e1c0 to d3e5647 Compare February 19, 2020 15:22
Only on non-Windows and non-macOS. The unit-ids become a bit longer:

Changes e.g.

    component cabal-fmt-0.1.2-ff4d3d1e89ec09722d5bccbf9724beeddb2bd9dcd99a200ff350860e49ecb0f2
        include cabal-fmt-0.1.2-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1
    unit cabal-fmt-0.1.2-ff4d3d1e89ec09722d5bccbf9724beeddb2bd9dcd99a200ff350860e49ecb0f2
        include cabal-fmt-0.1.2-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1

to

    component cabal-fmt-0.1.2-e-cabal-fmt-173382ac142508c938885649c3384b3512c441f46ff13c57cda2f345fe5f0859
        include cabal-fmt-0.1.2-l-cabal-fmt-internal-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1
    unit cabal-fmt-0.1.2-e-cabal-fmt-173382ac142508c938885649c3384b3512c441f46ff13c57cda2f345fe5f0859
        include cabal-fmt-0.1.2-l-cabal-fmt-internal-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1

i.e.

    cabal-fmt-0.1.2-....
    cabal-fmt-0.1.2-....

to

    cabal-fmt-0.1.2-e-cabal-fmt-...
    cabal-fmt-0.1.2-l-cabal-fmt-internal-...

This helps debugging, especially when public multilibs will become more
popular.

Resolves #6485
@phadej phadej force-pushed the issue-6485-unit-id-internal-lib branch from d3e5647 to caa9be6 Compare February 19, 2020 17:07
@phadej phadej merged commit b419865 into master Feb 19, 2020
@phadej phadej deleted the issue-6485-unit-id-internal-lib branch February 19, 2020 18:17
@phadej phadej mentioned this pull request Jul 10, 2020
@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit-Ids for internal libraries should have the internal lib name in them
1 participant