Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit-Ids for internal libraries should have the internal lib name in them #6485

Closed
phadej opened this issue Jan 17, 2020 · 0 comments · Fixed by #6547
Closed

Unit-Ids for internal libraries should have the internal lib name in them #6485

phadej opened this issue Jan 17, 2020 · 0 comments · Fixed by #6547
Milestone
3.4.0.0-rc1

Comments

@phadej
Copy link
Collaborator

phadej commented Jan 17, 2020 •
edited
Loading

At least on linux where path length isn't a problem.

This would help with figuring out what happens more easily, especially when you have plenty of internal libraries.
phadej added a commit that referenced this issue Feb 19, 2020
@phadej
Include component name in unit-id
8d1751f 
Only on non-Windows and non-macOS. The unit-ids become a bit longer:

Changes e.g.

    component cabal-fmt-0.1.2-ff4d3d1e89ec09722d5bccbf9724beeddb2bd9dcd99a200ff350860e49ecb0f2
        include cabal-fmt-0.1.2-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1
    unit cabal-fmt-0.1.2-ff4d3d1e89ec09722d5bccbf9724beeddb2bd9dcd99a200ff350860e49ecb0f2
        include cabal-fmt-0.1.2-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1

to

    component cabal-fmt-0.1.2-e-cabal-fmt-173382ac142508c938885649c3384b3512c441f46ff13c57cda2f345fe5f0859
        include cabal-fmt-0.1.2-l-cabal-fmt-internal-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1
    unit cabal-fmt-0.1.2-e-cabal-fmt-173382ac142508c938885649c3384b3512c441f46ff13c57cda2f345fe5f0859
        include cabal-fmt-0.1.2-l-cabal-fmt-internal-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1

Resolves #6485
phadej added a commit that referenced this issue Feb 19, 2020
@phadej
Include component name in unit-id
bb2e1c0 
Only on non-Windows and non-macOS. The unit-ids become a bit longer:

Changes e.g.

    component cabal-fmt-0.1.2-ff4d3d1e89ec09722d5bccbf9724beeddb2bd9dcd99a200ff350860e49ecb0f2
        include cabal-fmt-0.1.2-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1
    unit cabal-fmt-0.1.2-ff4d3d1e89ec09722d5bccbf9724beeddb2bd9dcd99a200ff350860e49ecb0f2
        include cabal-fmt-0.1.2-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1

to

    component cabal-fmt-0.1.2-e-cabal-fmt-173382ac142508c938885649c3384b3512c441f46ff13c57cda2f345fe5f0859
        include cabal-fmt-0.1.2-l-cabal-fmt-internal-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1
    unit cabal-fmt-0.1.2-e-cabal-fmt-173382ac142508c938885649c3384b3512c441f46ff13c57cda2f345fe5f0859
        include cabal-fmt-0.1.2-l-cabal-fmt-internal-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1

i.e.

    cabal-fmt-0.1.2-....
    cabal-fmt-0.1.2-....

to

    cabal-fmt-0.1.2-e-cabal-fmt-...
    cabal-fmt-0.1.2-l-cabal-fmt-internal-...

This helps debugging, especially when public multilibs will become more
popular.

Resolves #6485
@phadej phadej mentioned this issue Feb 19, 2020
Merged
phadej added a commit that referenced this issue Feb 19, 2020
@phadej
Include component name in unit-id
d3e5647 
Only on non-Windows and non-macOS. The unit-ids become a bit longer:

Changes e.g.

    component cabal-fmt-0.1.2-ff4d3d1e89ec09722d5bccbf9724beeddb2bd9dcd99a200ff350860e49ecb0f2
        include cabal-fmt-0.1.2-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1
    unit cabal-fmt-0.1.2-ff4d3d1e89ec09722d5bccbf9724beeddb2bd9dcd99a200ff350860e49ecb0f2
        include cabal-fmt-0.1.2-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1

to

    component cabal-fmt-0.1.2-e-cabal-fmt-173382ac142508c938885649c3384b3512c441f46ff13c57cda2f345fe5f0859
        include cabal-fmt-0.1.2-l-cabal-fmt-internal-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1
    unit cabal-fmt-0.1.2-e-cabal-fmt-173382ac142508c938885649c3384b3512c441f46ff13c57cda2f345fe5f0859
        include cabal-fmt-0.1.2-l-cabal-fmt-internal-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1

i.e.

    cabal-fmt-0.1.2-....
    cabal-fmt-0.1.2-....

to

    cabal-fmt-0.1.2-e-cabal-fmt-...
    cabal-fmt-0.1.2-l-cabal-fmt-internal-...

This helps debugging, especially when public multilibs will become more
popular.

Resolves #6485
phadej added a commit that referenced this issue Feb 19, 2020
@phadej
Include component name in unit-id
caa9be6 
Only on non-Windows and non-macOS. The unit-ids become a bit longer:

Changes e.g.

    component cabal-fmt-0.1.2-ff4d3d1e89ec09722d5bccbf9724beeddb2bd9dcd99a200ff350860e49ecb0f2
        include cabal-fmt-0.1.2-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1
    unit cabal-fmt-0.1.2-ff4d3d1e89ec09722d5bccbf9724beeddb2bd9dcd99a200ff350860e49ecb0f2
        include cabal-fmt-0.1.2-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1

to

    component cabal-fmt-0.1.2-e-cabal-fmt-173382ac142508c938885649c3384b3512c441f46ff13c57cda2f345fe5f0859
        include cabal-fmt-0.1.2-l-cabal-fmt-internal-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1
    unit cabal-fmt-0.1.2-e-cabal-fmt-173382ac142508c938885649c3384b3512c441f46ff13c57cda2f345fe5f0859
        include cabal-fmt-0.1.2-l-cabal-fmt-internal-3fc69567df6c17a860b37365e18b4b35f7d2e64ffdbab5d91cd775762ae888f1

i.e.

    cabal-fmt-0.1.2-....
    cabal-fmt-0.1.2-....

to

    cabal-fmt-0.1.2-e-cabal-fmt-...
    cabal-fmt-0.1.2-l-cabal-fmt-internal-...

This helps debugging, especially when public multilibs will become more
popular.

Resolves #6485
@phadej phadej mentioned this issue Jul 10, 2020
Merged
@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0.0-rc1
Development

Successfully merging a pull request may close this issue.

Include component name in unit-id haskell/cabal
1 participant
@phadej