Track the exact source of ghc-*-options related warnings #5598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkly
force-pushed
the
cabal-check-track-options-source-field
branch
2 times, most recently
from
c59b110 to
2b3f0cd
Compare
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 1, 2018
"url":"pull/5598", "account":"haskell", "repo":"cabal", "commit": "f055a5b0e51f6c68f449ad4b8247d95e93e6764f", "tag":"linux-7.10.3" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 1, 2018
"url":"pull/5598", "account":"haskell", "repo":"cabal", "commit": "f055a5b0e51f6c68f449ad4b8247d95e93e6764f", "tag":"linux-8.0.2" }
quasicomputational
approved these changes
Oct 1, 2018
cabal-install/changelog
Outdated
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| 2.6.0.0 (current development version) | |||
| * New solver flag: '--reject-unconstrained-dependencies'. (#2568) | |||
| * 'check' reports warnings for various ghc-\*-options fields separately | |||
There was a problem hiding this comment.
Since this is affecting Cabal-the-library, the changelog note should go in Cabal/changelog.
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 1, 2018
"url":"pull/5598", "account":"haskell", "repo":"cabal", "commit": "f055a5b0e51f6c68f449ad4b8247d95e93e6764f", "tag":"linux-7.6.3" }
Previously, when running `cabal check` all the various ghc-*-options flags were merged together, thus losing the information about the exact place of the warning. This PR implements separate checking of ghc-*-options, which allows us to give users more precise warnings. Fixes haskell#5342
nkly
force-pushed
the
cabal-check-track-options-source-field
branch
from
2b3f0cd to
3c1502b
Compare
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 1, 2018
"url":"pull/5598", "account":"haskell", "repo":"cabal", "commit": "f055a5b0e51f6c68f449ad4b8247d95e93e6764f", "tag":"osx-7.8.4" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 1, 2018
"url":"pull/5598", "account":"haskell", "repo":"cabal", "commit": "3c1502bb633b61ae4d24d40898fca66d7f169679", "tag":"linux-7.6.3" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 1, 2018
"url":"pull/5598", "account":"haskell", "repo":"cabal", "commit": "3c1502bb633b61ae4d24d40898fca66d7f169679", "tag":"linux-7.10.3" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 1, 2018
"url":"pull/5598", "account":"haskell", "repo":"cabal", "commit": "3c1502bb633b61ae4d24d40898fca66d7f169679", "tag":"linux-8.0.2" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 1, 2018
"url":"pull/5598", "account":"haskell", "repo":"cabal", "commit": "3c1502bb633b61ae4d24d40898fca66d7f169679", "tag":"linux-8.2.2" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 1, 2018
"url":"pull/5598", "account":"haskell", "repo":"cabal", "commit": "3c1502bb633b61ae4d24d40898fca66d7f169679", "tag":"linux-8.4.3" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 1, 2018
"url":"pull/5598", "account":"haskell", "repo":"cabal", "commit": "3c1502bb633b61ae4d24d40898fca66d7f169679", "tag":"osx-7.8.4" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 1, 2018
"url":"pull/5598", "account":"haskell", "repo":"cabal", "commit": "3c1502bb633b61ae4d24d40898fca66d7f169679", "tag":"linux-8.4.3-fdebug-expensive-assertions" }
haskell-pushbot
pushed a commit
to haskell-pushbot/cabal-binaries
that referenced
this pull request
Oct 1, 2018
"url":"pull/5598", "account":"haskell", "repo":"cabal", "commit": "3c1502bb633b61ae4d24d40898fca66d7f169679", "tag":"osx-8.0.2" }
|
Looks like one of the jobs failed by timeout, and another one got an error during dependency resolution. Both failures are unrelated to the changes in the PR. Is it okay to merge? |
|
I'd say to go for it. The solver error is happening on master, so it's not due to your code, and we bump right up against time limits on the OSX builders so it's inevitable that some builds get unlucky and time out. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when running
cabal checkall the various ghc-*-options flags were merged together, thus losing the information about the exact place of the warning. This PR implements separate checking of ghc-*-options, which allows us to give users more precise warnings.Fixes #5342
Checklist:
[ci skip]is used to avoid triggering the build bots.As for the testing approach, it is the same used for all other tests in the
Checkpackage.