-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cabal check mentions ghc-options when it could be ghc-shared-options #5342
Comments
Adding provenance information to that check should be relatively easy. See |
nkly
pushed a commit
to nkly/cabal
that referenced
this issue
Oct 1, 2018
Previously, when running `cabal check` all the various ghc-*-options flags were merged together, thus losing the information about the exact place of the warning. This PR implements separate checking of ghc-*-options, which allows us to give users more precise warnings. Fixes haskell#5342
nkly
pushed a commit
to nkly/cabal
that referenced
this issue
Oct 1, 2018
Previously, when running `cabal check` all the various ghc-*-options flags were merged together, thus losing the information about the exact place of the warning. This PR implements separate checking of ghc-*-options, which allows us to give users more precise warnings. Fixes haskell#5342
nkly
pushed a commit
to nkly/cabal
that referenced
this issue
Oct 1, 2018
Previously, when running `cabal check` all the various ghc-*-options flags were merged together, thus losing the information about the exact place of the warning. This PR implements separate checking of ghc-*-options, which allows us to give users more precise warnings. Fixes haskell#5342
nkly
pushed a commit
to nkly/cabal
that referenced
this issue
Oct 1, 2018
Previously, when running `cabal check` all the various ghc-*-options flags were merged together, thus losing the information about the exact place of the warning. This PR implements separate checking of ghc-*-options, which allows us to give users more precise warnings. Fixes haskell#5342
4 tasks
nkly
pushed a commit
to nkly/cabal
that referenced
this issue
Oct 1, 2018
Previously, when running `cabal check` all the various ghc-*-options flags were merged together, thus losing the information about the exact place of the warning. This PR implements separate checking of ghc-*-options, which allows us to give users more precise warnings. Fixes haskell#5342
nkly
pushed a commit
to nkly/cabal
that referenced
this issue
Oct 1, 2018
Previously, when running `cabal check` all the various ghc-*-options flags were merged together, thus losing the information about the exact place of the warning. This PR implements separate checking of ghc-*-options, which allows us to give users more precise warnings. Fixes haskell#5342
nkly
pushed a commit
to nkly/cabal
that referenced
this issue
Oct 1, 2018
Previously, when running `cabal check` all the various ghc-*-options flags were merged together, thus losing the information about the exact place of the warning. This PR implements separate checking of ghc-*-options, which allows us to give users more precise warnings. Fixes haskell#5342
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Title is self-explanatory. All the various
ghc-(shared-|prof-|)options
get smashed together in one list and if there's something warnable in there it's reported asghc-options
, which could send someone astray. Better would be keeping track of which field an option comes from and then reporting that.The text was updated successfully, but these errors were encountered: