Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal check mentions ghc-options when it could be ghc-shared-options #5342

Closed
quasicomputational opened this issue May 23, 2018 · 1 comment

Comments

@quasicomputational
Copy link
Contributor

quasicomputational commented May 23, 2018

Title is self-explanatory. All the various ghc-(shared-|prof-|)options get smashed together in one list and if there's something warnable in there it's reported as ghc-options, which could send someone astray. Better would be keeping track of which field an option comes from and then reporting that.

@23Skidoo
Copy link
Member

23Skidoo commented Jun 8, 2018

Adding provenance information to that check should be relatively easy. See Distribution.PackageDescription.Check.

nkly pushed a commit to nkly/cabal that referenced this issue Oct 1, 2018
Previously, when running `cabal check` all the various ghc-*-options
flags were merged together, thus losing the information about the exact
place of the warning. This PR implements separate checking of
ghc-*-options, which allows us to give users more precise warnings.

Fixes haskell#5342
nkly pushed a commit to nkly/cabal that referenced this issue Oct 1, 2018
Previously, when running `cabal check` all the various ghc-*-options
flags were merged together, thus losing the information about the exact
place of the warning. This PR implements separate checking of
ghc-*-options, which allows us to give users more precise warnings.

Fixes haskell#5342
nkly pushed a commit to nkly/cabal that referenced this issue Oct 1, 2018
Previously, when running `cabal check` all the various ghc-*-options
flags were merged together, thus losing the information about the exact
place of the warning. This PR implements separate checking of
ghc-*-options, which allows us to give users more precise warnings.

Fixes haskell#5342
nkly pushed a commit to nkly/cabal that referenced this issue Oct 1, 2018
Previously, when running `cabal check` all the various ghc-*-options
flags were merged together, thus losing the information about the exact
place of the warning. This PR implements separate checking of
ghc-*-options, which allows us to give users more precise warnings.

Fixes haskell#5342
nkly pushed a commit to nkly/cabal that referenced this issue Oct 1, 2018
Previously, when running `cabal check` all the various ghc-*-options
flags were merged together, thus losing the information about the exact
place of the warning. This PR implements separate checking of
ghc-*-options, which allows us to give users more precise warnings.

Fixes haskell#5342
nkly pushed a commit to nkly/cabal that referenced this issue Oct 1, 2018
Previously, when running `cabal check` all the various ghc-*-options
flags were merged together, thus losing the information about the exact
place of the warning. This PR implements separate checking of
ghc-*-options, which allows us to give users more precise warnings.

Fixes haskell#5342
nkly pushed a commit to nkly/cabal that referenced this issue Oct 1, 2018
Previously, when running `cabal check` all the various ghc-*-options
flags were merged together, thus losing the information about the exact
place of the warning. This PR implements separate checking of
ghc-*-options, which allows us to give users more precise warnings.

Fixes haskell#5342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants