-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please ensure cabal does not warn for incomplete-uni-patterns #6355
Comments
When you say "Could you please ensure that the following files do not give any warnings" and then give a list specifying 1 particular file, I assume you found that file to have warnings. But I'm having a hard time reproducing that, after adding that pragma and running |
I am currently implementing the above-mentioned proposal in GHC, i.e. that |
If you have a look at https://travis-ci.com/dwijnand/cabal/builds/136806769 and the commit it builds from (which builds on current HEAD), and ignore the failures on older GHCs, you'll see that compilation didn't fail (and I believe warnings are set to fatal), so I do still need some information as to what Parsec.hs needs or how to get it to fail... |
I'm saying that it will fail under |
Thanks to @phadej I found out that the information I was missing is that the "no" in |
[Edited the list to include many more cases I found!] |
Just out of curiosity, is there work on hadrian / shake to make them |
Or replace Just foo = rhs with foo = fromMaybe (error "...") rhs which there are plenty. I didn't tried to refactor these errors away, let cabal panic, if it hits them.
Or replace Just foo = rhs with foo = fromMaybe (error "...") rhs which there are plenty. I didn't tried to refactor these errors away, let cabal panic, if it hits them.
Or replace Just foo = rhs with foo = fromMaybe (error "...") rhs which there are plenty. I didn't tried to refactor these errors away, let cabal panic, if it hits them.
Resolve #6355: Fix most incomplete-uni-patterns
Or replace Just foo = rhs with foo = fromMaybe (error "...") rhs which there are plenty. I didn't tried to refactor these errors away, let cabal panic, if it hits them.
to be extra safe, prior to this warning being added to -Wall. See also * https://gitlab.haskell.org/ghc/ghc/-/issues/15656 * haskell#6355
to be extra safe, prior to this warning being added to -Wall. See also * https://gitlab.haskell.org/ghc/ghc/-/issues/15656 * haskell#6355
to be extra safe, prior to this warning being added to -Wall. See also * https://gitlab.haskell.org/ghc/ghc/-/issues/15656 * haskell#6355
to be extra safe, prior to this warning being added to -Wall. See also * https://gitlab.haskell.org/ghc/ghc/-/issues/15656 * haskell#6355
to be extra safe, prior to this warning being added to -Wall. See also * https://gitlab.haskell.org/ghc/ghc/-/issues/15656 * haskell#6355
to be extra safe, prior to this warning being added to -Wall. See also * https://gitlab.haskell.org/ghc/ghc/-/issues/15656 * haskell#6355
to be extra safe, prior to this warning being added to -Wall. See also * https://gitlab.haskell.org/ghc/ghc/-/issues/15656 * haskell#6355
to be extra safe, prior to this warning being added to -Wall. See also * https://gitlab.haskell.org/ghc/ghc/-/issues/15656 * haskell#6355
As per this accepted GHC proposal, GHC will add
incomplete-uni-patterns
andincomplete-record-updates
to-Wall
. Could you please ensure that the following files do not give any warnings forincomplete-uni-patterns
, perhaps by setting the pragma below? (A clean compile of cabal is needed to build GHC.){-# OPTIONS_GHC -Wno-incomplete-uni-patterns #-}
Cabal/Distribution/Backpack/Configure.hs
Cabal/Distribution/Parsec.hs
Cabal/Distribution/Simple/Build/Macros.hs
Cabal/Distribution/Simple/GHC.hs
Cabal/Distribution/Simple/GHCJS.hs
Cabal/Distribution/Simple/UHC.hs
Cabal/Distribution/Simple/Test/LibV09.hs
Cabal/Distribution/Simple/BuildTarget.hs
Cabal/Distribution/Simple/ShowBuildInfo.hs
Cabal/Cabal/Distribution/Simple/Haddock.hs
The text was updated successfully, but these errors were encountered: