Skip to content

Commit

Permalink
Parsec: Add -Wno-incomplete-uni-patterns
Browse files Browse the repository at this point in the history
  • Loading branch information
@dwijnand
dwijnand committed Nov 16, 2019
1 parent eb2f764 commit 4e6b2c5
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Cabal/Distribution/Parsec.hs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
{-# LANGUAGE GADTs #-}
{-# LANGUAGE RankNTypes #-}
{-# LANGUAGE ScopedTypeVariables #-}
{-# OPTIONS_GHC -Wno-incomplete-uni-patterns #-}
module Distribution.Parsec (
Parsec(..),
ParsecParser (..),
Expand Down

2 comments on commit 4e6b2c5

@phadej
Copy link

@phadej phadej commented on 4e6b2c5 Nov 17, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just fix the warnings.

Add -Wincomplete-uni-patterns to ghc-options in Cabal.cabal. (Note: it's not available on all GHCs we support, only on GHC-8.0+, older GHCs use -fwarn-incomplete-patterns, but it's ok not to enable the flag for them).

EDIT: there is a reason why that warning is added to -Wall.

@dwijnand
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I didn't realise the "no" was suppressing.

Thanks for the guidance, I'll try to submit something that works for all the versions.

Please sign in to comment.