Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with hinotify-0.3.10 #77

Merged
merged 2 commits into from
Apr 23, 2018

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Apr 11, 2018

close #75

From the ticket discussion:

hinotify switched to RawFilePath in 11c4d31a95ad36f954fac6728e47042a92e4466a

I looked into the commit kolmodin/hinotify@11c4d31 and implemented the conversions from/to ByteString that previously were done by hinotify. So the logic should've stayed the same

@simonmichael
Copy link

Ping ? If this could be merged and released, it would help me out in the hledger project.

simonmichael added a commit to simonmichael/hledger that referenced this pull request Apr 17, 2018
borsboom referenced this pull request in commercialhaskell/stack Apr 17, 2018
@borsboom
Copy link

I think this is the very last dependency blocking Stack from being build with GHC 8.4.

@UnkindPartition
Copy link
Member

Hey there,

Sorry for the silence — I don't really have time to maintain this package and must've unsubscribed from the notifications at some point. I'll merge and release this PR (thanks for writing the patch, Dmitry!), and then will look for a new maintainer and/or home for this project.

Does anyone here want to step in as an active maintainer by any chance?

@UnkindPartition UnkindPartition merged commit 4dfb2f1 into haskell-fswatch:master Apr 23, 2018
@UnkindPartition
Copy link
Member

This is now released as fsnotify-0.2.1.2.

@borsboom
Copy link

Thank you!

@simonmichael
Copy link

Thanks @feuerbach. https://github.com/fpco/stackage/blob/master/build-constraints.yaml can now be updated too, re-enabling all packages marked with "via hinotify" or "via fsnotify". Or if you'd prefer, I can submit the PR.

@4e6 4e6 deleted the raw-file-path branch April 24, 2018 06:31
@4e6 4e6 restored the raw-file-path branch April 24, 2018 06:31
@simonmichael
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support hinotify master
4 participants