Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support hinotify master #75

Closed
avieth opened this issue Mar 28, 2018 · 1 comment · Fixed by #77
Closed

Support hinotify master #75

avieth opened this issue Mar 28, 2018 · 1 comment · Fixed by #77

Comments

@avieth
Copy link

avieth commented Mar 28, 2018 •
edited
Loading

hinotify now uses ByteString rather than [Char] for file paths (RawFilePath).

kolmodin/hinotify#19
kolmodin/hinotify@106930c

Somehow this didn't make it into the changelog for that package. because it's not yet released :)
@avieth avieth changed the title Support hinotify 0.3.9 and higher Support hinotify ~0.3.9 and higher~ master Mar 28, 2018
@avieth avieth changed the title Support hinotify ~0.3.9 and higher~ master Support hinotify ~~0.3.9 and higher~~ master Mar 28, 2018
@avieth avieth changed the title Support hinotify ~~0.3.9 and higher~~ master Support hinotify master Mar 28, 2018
@jchia
Copy link

jchia commented Apr 9, 2018 •
edited
Loading

hinotify switched to RawFilePath in 11c4d31a95ad36f954fac6728e47042a92e4466a, quite a while ago, and there was a new hackage release a few days ago that uses RawFilePath. Previously, it was using GHC.IO.Encoding.getFileSystemEncoding together with GHC.Foreign.withCString to convert from ByteString to FilePath. Now that hinotify is no longer doing that decoding, should hsnotify start doing it for newer versions of hinotify?

In short, what is to be done about the filename encoding?

This issue is blocking the inclusion of fsnotify in stackage nightly.

@jchia jchia mentioned this issue Apr 9, 2018
Merged
@simonmichael simonmichael mentioned this issue Apr 9, 2018
Closed
@4e6 4e6 mentioned this issue Apr 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add compatibility with hinotify-0.3.10 4e6/hfsnotify
2 participants
@jchia @avieth