Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Support for GHC 9 in basement #549

Closed
wants to merge 1 commit into from
Closed

Support for GHC 9 in basement #549

wants to merge 1 commit into from

Conversation

LaurentRDC
Copy link

@LaurentRDC LaurentRDC commented Feb 5, 2021

This PR fixes #536 and fixes #548.

I could not test with ghc-9.0.1 on my machine, but at least the tests pass for GHC 8.

@LaurentRDC LaurentRDC changed the title Location of unsafeCoerce# has changed in base 4.15+ Support for GHC 9 Feb 5, 2021
@LaurentRDC
Copy link
Author

I don't understand where is the problem involving Prelude.chr

@Bodigrim

This comment was marked as spam.

@Bodigrim

This comment was marked as spam.

@LaurentRDC
Copy link
Author

Allright, thank you. I guess this PR is blocked until then, unless someone else can test locally with GHC 9

@harendra-kumar
Copy link

@LaurentRDC I have tested it with GHC 9.0, built gauge with it successfully. I think we can go ahead an commit it if someone has reviewed it.

@LaurentRDC
Copy link
Author

Great, I removed the CI test for GHC 9. It's ready to go!

@LaurentRDC
Copy link
Author

@haskell-foundation Can someone take a look at this? Thanks!

@danwdart
Copy link

This certainly seems to compile well for me.

@WillSewell
Copy link

Great to see GHC 9 support added to basement in this PR. However support still needs to be added to foundation: #551. That might not be clear from this PR title/description.

@LaurentRDC LaurentRDC changed the title Support for GHC 9 Support for GHC 9 in basement Mar 29, 2021
@patrickt
Copy link

patrickt commented Apr 1, 2021

Would love to see this merged, as the fact that basement doesn’t build means gauge and thereby fused-effects can’t move to GHC 9 yet.

@EmilGedda
Copy link

Great to see GHC 9 support added to basement in this PR. However support still needs to be added to foundation: #551. That might not be clear from this PR title/description.

There is already a fix for #551 (which would be the PR #540), which is just waiting for approval and merge.

@Bodigrim

This comment was marked as spam.

@LaurentRDC
Copy link
Author

This PR has been superseeded by commit 3c19590 so I'm closing it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
7 participants