This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
Eta convert a lambda to fix GHC 9 type error #540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this code did not compile on (soon to be released GHC 9). I think it is caused by the simplified subsumption work[1]. [1]: https://gitlab.haskell.org/ghc/ghc/-/wikis/migration/9.0#simplified-subsumption
|
(CI seem to have failed for a different reason) |
This was referenced Apr 1, 2021
|
I was able to compile foundation with current master and change from this pull request under ghc-9.0.1 |
ghost
mentioned this pull request
|
oh, I missed this PR. I applied effectively the exact same patch from the nix closure description in another ticket |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this code did not compile on (soon to be released GHC 9). I think it is caused by the simplified subsumption work.
I was able to compile
foundationon GHC 9 with this change alongside with #538 and #537.