UI/transit add missed algorithms follow up #9520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andaley
force-pushed
the
ui/transit-add-missed-algorithms
branch
from
9cc232f to
f25c3ff
Compare
andaley
changed the title
Monkeychip
approved these changes
Jul 17, 2020
Monkeychip
pushed a commit
that referenced
this pull request
Aug 11, 2020
* fix NaN error for version history of aes128-gcm96 transit secrets * convert aes128-gcm96 keys to milliseconds to work with date-frmo-now helper
Monkeychip
pushed a commit
that referenced
this pull request
Aug 11, 2020
* fix NaN error for version history of aes128-gcm96 transit secrets * convert aes128-gcm96 keys to milliseconds to work with date-frmo-now helper
chelshaw
pushed a commit
that referenced
this pull request
Aug 12, 2020
* fix NaN error for version history of aes128-gcm96 transit secrets * convert aes128-gcm96 keys to milliseconds to work with date-frmo-now helper Co-authored-by: Noelle Daley <[email protected]>
chelshaw
pushed a commit
that referenced
this pull request
Aug 12, 2020
* fix NaN error for version history of aes128-gcm96 transit secrets * convert aes128-gcm96 keys to milliseconds to work with date-frmo-now helper Co-authored-by: Noelle Daley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show correct transit key version date
This PR is a follow up to #9070, which adds the
aes128-gcm96,ecdsa-p384, andecdsa-p521transit key versions to the UI. The PR surfaced another bug where we were showing the incorrect timestamp on the transit key show page for theaes128-gcm96key type. To solve it, we updated the serializer to convert the timestamp to milliseconds (which is what our date helpers expect). We already have to do for several other key types as well. This PR from last year fixes the same problem.The Changes: Transit Keys
These transit key types are now shown in the UI. Without the fix, the timestamp for version 1 and 2 used to say "more than 50 years ago".
Testing
In the UI, create each type of transit key. Navigate to the versions tab and rotate the encryption key. You should be able to see the version with the correct version timestamp.