-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missed algorithms aes128-gcm96, ecdsa-p384, ecdsa-p521 in UI #9070
Merged
andaley
merged 10 commits into
hashicorp:master
from
binlab:ui/transit-add-missed-algorithms
Jul 17, 2020
Merged
Add missed algorithms aes128-gcm96, ecdsa-p384, ecdsa-p521 in UI #9070
andaley
merged 10 commits into
hashicorp:master
from
binlab:ui/transit-add-missed-algorithms
Jul 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @binlab! Thank you so much for contributing this change. Your fix surfaced another bug which we're working on resolving at the moment. We'll merge this once we've narrowed that down. Stay tuned! :) |
Closed
This is merged and will be included in our next minor release. Thanks again and great work! |
Thank you! |
Monkeychip
pushed a commit
that referenced
this pull request
Aug 11, 2020
Co-authored-by: Noelle Daley <[email protected]>
Monkeychip
pushed a commit
that referenced
this pull request
Aug 11, 2020
Co-authored-by: Noelle Daley <[email protected]>
chelshaw
pushed a commit
that referenced
this pull request
Aug 12, 2020
Co-authored-by: Noelle Daley <[email protected]> Co-authored-by: Mark <[email protected]> Co-authored-by: Noelle Daley <[email protected]>
chelshaw
pushed a commit
that referenced
this pull request
Aug 12, 2020
Co-authored-by: Noelle Daley <[email protected]> Co-authored-by: Mark <[email protected]> Co-authored-by: Noelle Daley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue described here - #9069. This should solve it