Sync Protobuf dependencies between core and sdk #9154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catsby
added
dependencies
jefferai
approved these changes
Jun 5, 2020
catsby
added a commit
that referenced
this pull request
Jun 5, 2020
* master: Sync Protobuf dependencies between core and sdk (#9154) Document and give an example of the input size limits when using the FF3-1 transform. (#9151) Fix feature flag persistence: we shouldn't have excluded dr primaries, they too must write feature flags. DR secondaries might not need depend on feature flags being there, but a DR primary could also be (or become) a perf primary. (#9148)
andaley
pushed a commit
that referenced
this pull request
Jul 17, 2020
* update go.mod/sum for root and sdk folders to sync protobuf versions * run 'go mod vendor' * bump github.com/golang/protobuf to v1.4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR synchronizes the version of protocol buffers and associate libraries used in core and the sdk to be on the same versions.
github.com/golang/protobuf v1.4.2-> https://github.com/golang/protobufgoogle.golang.org/protobuf v1.24.0-> https://github.com/protocolbuffers/protobuf-go