Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and give an example of the input size limits when using the FF3-1 transform. #9151

Merged
merged 3 commits into from
Jun 5, 2020

Conversation

sgmiller
Copy link
Collaborator

@sgmiller sgmiller commented Jun 4, 2020

A calculator might have been nice. :)

@sgmiller sgmiller requested a review from calvn June 4, 2020 20:49
@sgmiller sgmiller added the website Code changes specifically for the docs website label Jun 4, 2020
calvn
calvn previously approved these changes Jun 4, 2020
Copy link
Contributor

@calvn calvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise looks good. Thanks for updating this!

@calvn
Copy link
Contributor

calvn commented Jun 4, 2020

Added the docs-cherrypick label to this so that it can be automatically cherry-picked.

@sgmiller sgmiller merged commit 6d37057 into master Jun 5, 2020
@sgmiller sgmiller deleted the ff3-1-limit-docs branch June 5, 2020 12:45
github-actions bot pushed a commit that referenced this pull request Jun 5, 2020
…FF3-1 transform. (#9151)

* Document and give an example of the input size limits when using the FF3-1
transform.
catsby added a commit that referenced this pull request Jun 5, 2020
* master:
  Sync Protobuf dependencies between core and sdk (#9154)
  Document and give an example of the input size limits when using the FF3-1 transform. (#9151)
  Fix feature flag persistence: we shouldn't have excluded dr primaries, they too must write feature flags. DR secondaries might not need depend on feature flags being there, but a DR primary could also be (or become) a perf primary. (#9148)
andaley pushed a commit that referenced this pull request Jul 17, 2020
…FF3-1 transform. (#9151)

* Document and give an example of the input size limits when using the FF3-1
transform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Code changes specifically for the docs website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants