Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse web CLI input as shell input #7206

Merged
merged 5 commits into from
Aug 1, 2019
Merged

parse web CLI input as shell input #7206

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ce7aeb9
add shell quote
meirish Jul 26, 2019
d6f4a00
use shell quote's parse method to properly escape strings entered in …
meirish Jul 29, 2019
3eb7ed7
add and update tests for the web CLI
meirish Jul 29, 2019
c8ccff4
fix linting and skip test for ' in a path
meirish Jul 29, 2019
3c763e4
skip the correct test
meirish Jul 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ui/tests/acceptance/secrets/backend/kv/secret-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,8 @@ module('Acceptance | secrets/secret/create', function(hooks) {
let paths = [
'(',
')',
//'"',
"'",
'"',
//"'",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why'd you skip this test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had previously skipped both of them because they weren't supported in the web CLI - we do use those values for manual input into the regular KV ui below though. With this change we could do " because we now require that you quote the whole path. But we're quoting the path with ' which doesn't work when the path also contains '.

'!',
'#',
'$',
Expand Down