parse web CLI input as shell input #7206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andaley
reviewed
Aug 1, 2019
| //'"', | ||
| "'", | ||
| '"', | ||
| //"'", |
There was a problem hiding this comment.
We had previously skipped both of them because they weren't supported in the web CLI - we do use those values for manual input into the regular KV ui below though. With this change we could do " because we now require that you quote the whole path. But we're quoting the path with ' which doesn't work when the path also contains '.
andaley
approved these changes
Aug 1, 2019
meirish
added a commit
that referenced
this pull request
Aug 5, 2019
* add shell quote * use shell quote's parse method to properly escape strings entered in the web cli * add and update tests for the web CLI * fix linting and skip test for ' in a path * skip the correct test
meirish
added a commit
that referenced
this pull request
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal with the web CLI is to have it be compatible with some low level vault CLI commands, but there have been instances of users assuming this compatibility and the implementation falling short. The major case where this has surfaced is escaping shell characters, so this PR adds shell-quote to remedy that.
Previously the web CLI allowed use of unquoted shell characters in paths - quoting them is now required.
Fixes #7156 and #6227