UI - support redirecting to an intended URL after authentication #7088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meirish
force-pushed
the
ui-redirect-to
branch
2 times, most recently
from
76e4092 to
df728d5
Compare
andaley
previously approved these changes
Aug 1, 2019
…he redirect_to query param
…oot don't end up in redirect_to
meirish
added a commit
that referenced
this pull request
Aug 5, 2019
* add redirect_to query param * alias auth controller state to vault controller where the query param is defined * capture the current url before redirecting a user to auth if they're being redirected * consume and reset the redirectTo query param when authenticating * make sure that the current url when logging out does not get set as the redirect_to query param * add unit tests for the mixin and make it so that redirects from the root don't end up in redirect_to * acceptance tests for redirect
meirish
added a commit
that referenced
this pull request
Aug 5, 2019
* add redirect_to query param * alias auth controller state to vault controller where the query param is defined * capture the current url before redirecting a user to auth if they're being redirected * consume and reset the redirectTo query param when authenticating * make sure that the current url when logging out does not get set as the redirect_to query param * add unit tests for the mixin and make it so that redirects from the root don't end up in redirect_to * acceptance tests for redirect
meirish
added a commit
that referenced
this pull request
Aug 5, 2019
…) (#7263) * add redirect_to query param * alias auth controller state to vault controller where the query param is defined * capture the current url before redirecting a user to auth if they're being redirected * consume and reset the redirectTo query param when authenticating * make sure that the current url when logging out does not get set as the redirect_to query param * add unit tests for the mixin and make it so that redirects from the root don't end up in redirect_to * acceptance tests for redirect
|
Thanks a lot, this is awesome @meirish! I'm trying to get the functionality described in #5107 to work, but when I visit the following URL: I expect to be:
Steps 1. and 2. work, however the redirect after login does not happen. Am I doing something wrong? |
|
Hey @zx8 ! It looks like I added a redirect that clears the query param on logout to fix a different issue and I forgot about the original use case - sorry about that! I'll create an issue to allow the use of both of them on the logout route. |
|
@meirish Thanks a lot. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you're unauthenticated and you try to follow a link to a deeper page, the UI will boot you out to authenticate, but then just send you back to the secret engines list page upon successful authentication.
This PR changes that behavior so that if you're being redirected to authenticate, we save the url to the
redirect_toquery param which is then used in the auth-form.js component.Fixes #7068