Skip to content

Commit

Permalink
acceptance tests for redirect
Browse files Browse the repository at this point in the history
  • Loading branch information
meirish committed Jul 11, 2019
1 parent f70426d commit df728d5
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 10 deletions.
10 changes: 0 additions & 10 deletions ui/app/mixins/cluster-route.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,6 @@ export default Mixin.create({
targetRoute !== transition.targetName &&
targetRoute !== this.router.currentRouteName
) {
console.log(
'routeName: ',
this.routeName,
' targetName: ',
transition.targetName,
' targetRoute: ',
targetRoute,
' currentRouteName: ',
this.router.currentRouteName
);
if (
// only want to redirect if we're going to authenticate
targetRoute === AUTH &&
Expand Down
39 changes: 39 additions & 0 deletions ui/tests/acceptance/redirect-to-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
import { currentURL, visit } from '@ember/test-helpers';
import { module, test } from 'qunit';
import { setupApplicationTest } from 'ember-qunit';
import authPage from 'vault/tests/pages/auth';

module('Acceptance | redirect_to functionality', function(hooks) {
setupApplicationTest(hooks);

test('redirect to a route after authentication', async function(assert) {
let url = '/vault/secrets/secret/create';
await visit(url);
assert.equal(
currentURL(),
`/vault/auth?redirect_to=${encodeURIComponent(url)}&with=token`,
'encodes url for the query param'
);
// the login method on this page does another visit call that we don't want here
await authPage.tokenInput('root').submit();
assert.equal(currentURL(), url, 'navigates to the redirect_to url after auth');
});

test('redirect from root does not include redirect_to', async function(assert) {
let url = '/';
await visit(url);
assert.equal(currentURL(), `/vault/auth?with=token`, 'there is no redirect_to query param');
});

test('redirect to a route after authentication with a query param', async function(assert) {
let url = '/vault/secrets/secret/create?initialKey=hello';
await visit(url);
assert.equal(
currentURL(),
`/vault/auth?redirect_to=${encodeURIComponent(url)}&with=token`,
'encodes url for the query param'
);
await authPage.tokenInput('root').submit();
assert.equal(currentURL(), url, 'navigates to the redirect_to with the query param after auth');
});
});

0 comments on commit df728d5

Please sign in to comment.