Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI ember engines #6718

Merged
merged 68 commits into from
May 13, 2019
Merged

UI ember engines #6718

merged 68 commits into from
May 13, 2019

Conversation

meirish
Copy link
Contributor

@meirish meirish commented May 10, 2019 •
edited
Loading

This is the feature branch for two foundational PRs where we're starting to use Ember Engines. You can read more about it in the PRs:
#6629
#6707

The last 4 commits are additional fixes that weren't present in those PRs.

There's some follow on work once this is in, but it makes sense to get it into master now so that it doesn't block other work the team is doing.

Follow on work includes (after the merge):

  • Adding documentation about svg-jar and ember engines to the ui/README.md
  • Adding a @SiZe prop to the Icon component so that we're not leaking component classes all over the application

meirish added 30 commits May 9, 2019 20:54
@meirish
add initializer hook to mount engines inside the cluster route
cd31733
@meirish
add ember-engines and an in-repo addon
d172a5b
@meirish
start moving components needed for replication to core addon
0bff315
@meirish
move replication routes to a lazy engine
9079a14
@meirish
add assetLoader block to the build to support rootURL for engines
a7f6ebd
@meirish
share template addons in the core addon
e25dbba
@meirish
share services with the replication engine
0881573
@meirish
move replication code over to the replication engine
384b9a2
@meirish
move shared components to core and replication components to replicat…
2f4b6df 
…ion engine, remove some partials
@meirish
move shared helpers and utils to core
a6cf9b4
@meirish
move named replication route to addon application route
e7ab398
@meirish
update shared services and core addon deps
fa7a39a
@meirish
comment out usage of i-con component for now
f657fc4
@meirish
share info-table-row, is-active-route helper, ember-cli-string-helpers
e1470a8
@meirish
change route names to be relative to the replication engine
2684b28
@meirish
share confirm-action and doc-link components
22c0729
@meirish
share namespace service
ea22005
@meirish
share ttl-picker component
b4efee9
@meirish
more relative routes and move params checking to the model hook inste…
313e041 
…ad of using paramsFor
@meirish
fix ttl component sharing
e90faf6
@meirish
fix routing issue with using cluster name in engine route
06a3745
@meirish
move replication partials to components in the replication engine
31c5133
@meirish
share alert-inline component and message-types helper
d2a9337
@meirish
remove test component
73e5ed3
@meirish
fix non-replication tests
5e8130a
@meirish
remove reduce-to-array helper
2d4507c
@meirish
rework components that came from partials
679f45e
@meirish
move vault-loading and loading partials to shared components in core
28b0c55
@meirish
share upgrade-page and mount-filter-config-list
bba3293
@meirish
remove includes helper, use contains from ember-composable-helpers
fe23b01
meirish and others added 25 commits May 9, 2019 20:59
@meirish
OR the search for component usage to match curly or angle bracket syntax
9bf44b9
@meirish
move new components to core addon and comment out ICon usage
1abbb9e
@meirish
Merge pull request #6712 from hashicorp/ui-engines-share-toolbar
d949ab7 
UI engines share toolbar
@meirish
add ember-svg-jar
9ac3abd
@meirish
add new icon component
563ffcc
@meirish
use icon in core alert components
70794df
@meirish
move replication svgs to the public folder and use new icon in rempli…
81a8ece 
…cation-summary component
@meirish
fix ember-svg-jar so we can run the ember app locally
f72e432
@meirish
replace i-con with icon in the core addon
bc50067
@meirish
add chevron component
3d8b11b
@meirish
move icons enable icons to public/eco and rename to svg
8a2a8f2
@meirish
use icon instead of i-con in host application
9779762
@meirish
replace ICon with Icon in the host app
c54cad7
@meirish
add structure-icons css to the host app's build
aacc1c2
@meirish
fix warning icon
22eb533
@meirish
use file path for the source link when generating story markdown
b36dda2
@meirish
add chevron and icon to storybook, remove i-con storybook
7650ec3
@meirish
remove old i-con, add tests for icon and chevron components
de84917
@meirish
migrate toolbar usage from ICon to Icon
f65c0d6
@meirish
fix search icon positioning
e9e7dc9
@meirish
Merge pull request #6707 from hashicorp/ui-new-icon
c440f50 
UI - new Icon and Chevron components
@meirish
move upgrade-link to core addon
e0ec6d4
@meirish
use has-block helper instead of hasBlock property on a component
38d1662
@meirish
move is-version to core
a627670
@meirish
unbreak the design from moving over things to engines
8213723
madalynrose
madalynrose reviewed May 10, 2019
View reviewed changes
ui/app/templates/components/identity/item-details.hbs Outdated
@@ -1,5 +1,5 @@
<div class="box is-shadowless is-marginless is-fullwidth">
{{#if model.disabled}}
{{#if (and model.disabled)}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha whoops, that was left in from a debug - that's how I found the (has-block) issue - I'll remove this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@meirish meirish merged commit 6d273dc into master May 13, 2019
@meirish meirish deleted the ui-ember-engines branch May 13, 2019 19:05
catsby added a commit that referenced this pull request May 16, 2019
@catsby
Merge branch 'master' into cdcr-backend-grpc
da1b8cc 
* master: (85 commits)
  UI icon - add size (#6736)
  Add Priority Queue library to sdk (#6664)
  Add spellcheck="false" to form fields (#6744)
  Maximum typo in Vault UI (#6743)
  docs: Fix Markdown formatting error in AWS Auth (#6745)
  changelog++
  Update OIDC Provider Setup docs (#6739)
  Update to use newer sdk
  Copy LogInput from audit package, add OptMarshaler interface  (#6735)
  docs: fixed typo (#6732)
  Fix typo
  changelog++
  Use Go modules in CircleCI (#6729)
  Fix recovery key backup path documentation
  Vendoring updated grpc
  Add link to R client on libraries list (#6722)
  UI ember engines (#6718)
  changelog++
  Update grpc and protos (#6725)
  changelog++
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madalynrose madalynrose madalynrose left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meirish @madalynrose