Add Priority Queue library to sdk #6664
Conversation
… Other cleanup after feedback
| type PriorityQueue struct { | ||
| // data is the internal structure that holds the queue, and is operated on by | ||
| // heap functions | ||
| data queue |
There was a problem hiding this comment.
Should this be a pointer to the queue instead of the queue object? I see other places where you just pass the reference and that could just be stored here.
There was a problem hiding this comment.
So that I understand what you're asking, are the other places heap methods like heap.Init(&pq.data) and heap.Pop(&pq.data).(*Item), and you're asking if we make data a *queue instead of queue, so those calls are heap.Init(pq.data) et. al?
Assuming that's what you're asking, is there an advantage to doing that? I'm not opposed to it I'm just curious of the benefits.
There was a problem hiding this comment.
I'm fine either way, it just seems that you are always using the reference to it in all calls instead of just storing the reference and just using it directly. It is really just a stylistic thing. If I see a bunch of & for the same thing, I start digging into the implementation.
* master: (85 commits) UI icon - add size (#6736) Add Priority Queue library to sdk (#6664) Add spellcheck="false" to form fields (#6744) Maximum typo in Vault UI (#6743) docs: Fix Markdown formatting error in AWS Auth (#6745) changelog++ Update OIDC Provider Setup docs (#6739) Update to use newer sdk Copy LogInput from audit package, add OptMarshaler interface (#6735) docs: fixed typo (#6732) Fix typo changelog++ Use Go modules in CircleCI (#6729) Fix recovery key backup path documentation Vendoring updated grpc Add link to R client on libraries list (#6722) UI ember engines (#6718) changelog++ Update grpc and protos (#6725) changelog++ ...
This pull request adds a Priority Queue package to Vault's SDK. The first use-case will be used by plugins to maintain an in-memory priority queue to perform periodic actions on, which will be added in upcoming pull requests following this one.