Restore plugin name for backwards compatibility #5825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 20, 2018
calvn
reviewed
Nov 20, 2018
Co-Authored-By: tyrannosaurus-becks <[email protected]>
Co-Authored-By: tyrannosaurus-becks <[email protected]>
…hicorp/vault into restore-plugin-name-for-compat
calvn
reviewed
Nov 20, 2018
| @@ -143,7 +143,7 @@ func (c *AuthListCommand) detailedMounts(auths map[string]*api.AuthMount) []stri | |||
| } | |||
| } | |||
|
|
|||
| out := []string{"Path | Type | Accessor | Plugin | Default TTL | Max TTL | Token Type | Replication | Seal Wrap | Options | Description"} | |||
| out := []string{"Path | Plugin | Accessor | Default TTL | Max TTL | Token Type | Replication | Seal Wrap | Options | Description"} | |||
There was a problem hiding this comment.
Should it be "Plugin" or "Type"?
There was a problem hiding this comment.
Brian had commented s/Type/Plugin/. I can go the other way if that's desired, but we should all agree.
There was a problem hiding this comment.
I think it's fine to just say "Plugin" now since everything is a plugin
There was a problem hiding this comment.
👍It might look weird listing older servers since that's not the case, but probably not a big deal.
calvn
approved these changes
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.