Remove Plugin from detailed output

[catsby]

Remove Plugin from the output of secrets list --detailed, which was removed in #5536

[tyrannosaurus-becks]

@catsby good find! This makes me realize the following place would need the same:

• https://github.com/hashicorp/vault/blob/master/command/auth_list.go#L146

[briankassouf]

So this breaks bc with older versions of vault, and i think 1.0 could still return a mount with plugin_name defined. I think instead we should dynamically add the column if any of the mounts have a value set for plugin_name

[jefferai]

TBH I'd go the other way -- now that everything is a plugin, we should instead add this back from #5536 and always output the plugin being used, which I believe may actually be different from the type in some cases due to plugin_name. My $0.02.

[catsby]

I agree with Jeff, it seems that Plugin is more relevant now that everything is a plugin

[tyrannosaurus-becks]

@catsby @jefferai #5807

[calvn]

Couldn't we have the "Type" return the plugin name instead?

Pre-1.0.0:

# vault secrets list -detailed (partial result)
Type     Plugin 
----     ------
plugin   gen

1.0.0:

# vault secrets list -detailed (partial result)
Type    
----    
gen

[tyrannosaurus-becks]

@calvn I believe your comment is addressed in #5825

[briankassouf]

superseded by #5825