Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of VAULT-24945: audit - add context timeout to audit request into release/1.16.x #26802

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core commented May 3, 2024

Backport

This PR is auto-generated from #26616 to be assessed for backporting due to the inclusion of the label backport/1.16.x.

The below text is copied from the body of the original PR.


As per: #24238, but for auditing requests.

This PR updates the logic used for request and response to check whether the existing context would suffice.


Overview of commits

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 3, 2024
Copy link

hashicorp-cla-app bot commented May 3, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented May 3, 2024

CI Results:
All Go tests succeeded! ✅

* Ensure 'minimum' timeout for contexts when attempting to send audit entries to the broker
@peteski22 peteski22 force-pushed the backport/peteski22/VAULT-24945/audit-request-timeout/slowly-concrete-phoenix branch from b52a6d5 to afd7d8e Compare May 3, 2024 10:13
@peteski22 peteski22 marked this pull request as ready for review May 3, 2024 10:14
Copy link

github-actions bot commented May 3, 2024

Build Results:
All builds succeeded! ✅

@peteski22 peteski22 merged commit 3ee5c4b into release/1.16.x May 3, 2024
76 checks passed
@peteski22 peteski22 deleted the backport/peteski22/VAULT-24945/audit-request-timeout/slowly-concrete-phoenix branch May 3, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants