Audit: logging a response uses a separate 5 second timeout #24238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for logging a response
peteski22
added
core/audit
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
raskchanky
approved these changes
Nov 22, 2023
| @@ -10,6 +10,8 @@ import ( | |||
| "sync" | |||
| "time" | |||
|
|
|||
| "github.com/hashicorp/vault/helper/namespace" | |||
|
|
|||
There was a problem hiding this comment.
The extra blank line strikes again!
There was a problem hiding this comment.
But the cat came back the very next day,
the cat came back, they thought he was a goner.
But the cat came back; it just couldn’t stay away.
raskchanky
deleted the
peteski22/fix/audit-log-response-context-timeout
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a potential issue with not attempting to audit log a response in which the context is already
Done.Should resolve: #23871
(5 seconds was a sensible value that came from a conversation with @ncabatoff)