Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: fix replication nav 1.16.x #26350

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Conversation

hashishaw
Copy link
Contributor

The changes in #26325 did not completely fix the issue for 1.16 because in 1.17 and beyond, replication-page is a glimmer component, but in 1.16 and before it's a classic component. This PR updates the the calculation of mode-specific attributes for the replication-page component so that the tests pass.

@hashishaw hashishaw added this to the 1.16.2 milestone Apr 10, 2024
@hashishaw hashishaw requested review from a team as code owners April 10, 2024 18:17
@hashishaw hashishaw changed the base branch from main to release/1.16.x April 10, 2024 18:17
@hashishaw hashishaw enabled auto-merge (squash) April 10, 2024 20:52
@hashishaw hashishaw disabled auto-merge April 10, 2024 21:27
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 11, 2024
Copy link

Build Results:
All builds succeeded! ✅

Copy link

CI Results:
All Go tests succeeded! ✅

@hashishaw hashishaw merged commit 1fb64fe into release/1.16.x Apr 11, 2024
24 checks passed
@hashishaw hashishaw deleted the ui/fix-replication-nav-1.16.x branch April 11, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants