UI: Replication page navigation fix #26325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cationAttrs which wasn't triggering component updates
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
andaley
approved these changes
Apr 9, 2024
| @@ -38,7 +38,9 @@ export default Component.extend(ReplicationActions, DEFAULTS, { | |||
| initialReplicationMode: null, | |||
| cluster: null, | |||
|
|
|||
| replicationAttrs: alias('cluster.replicationAttrs'), | |||
There was a problem hiding this comment.
wow, i totally forgot about alias ever being a thing. it's like time traveling! 😛
This was referenced Apr 10, 2024
hashishaw
added a commit
that referenced
this pull request
Apr 10, 2024
* Add replication mirage handler * Add test with skipped failed assertion * Use component-calculated attrsForCurrentMode instead of cluster.replicationAttrs which wasn't triggering component updates * assert previously-skipped assertion * Add changelog
hashishaw
added a commit
that referenced
this pull request
Apr 10, 2024
* Add replication mirage handler * Add test with skipped failed assertion * Use component-calculated attrsForCurrentMode instead of cluster.replicationAttrs which wasn't triggering component updates * assert previously-skipped assertion * Add changelog
This was referenced Apr 10, 2024
hashishaw
added a commit
that referenced
this pull request
Apr 10, 2024
* Add replication mirage handler * Add test with skipped failed assertion * Use component-calculated attrsForCurrentMode instead of cluster.replicationAttrs which wasn't triggering component updates * assert previously-skipped assertion * Add changelog
hashishaw
added a commit
that referenced
this pull request
Apr 10, 2024
* Add replication mirage handler * Add test with skipped failed assertion * Use component-calculated attrsForCurrentMode instead of cluster.replicationAttrs which wasn't triggering component updates * assert previously-skipped assertion * Add changelog
This was referenced Apr 10, 2024
akshya96
pushed a commit
that referenced
this pull request
Apr 11, 2024
* Add replication mirage handler * Add test with skipped failed assertion * Use component-calculated attrsForCurrentMode instead of cluster.replicationAttrs which wasn't triggering component updates * assert previously-skipped assertion * Add changelog
akshya96
added a commit
that referenced
this pull request
Apr 12, 2024
….15.x (#26143) * Change minimum retention window CE changes (#26118) * Retention window oss changes * latest oss changes * remove operator_diagnose change * backport of commit da21b85 (#25666) Co-authored-by: Scott Miller <[email protected]> * headers only modified if we have a header formatter and headers (#26140) * backport of commit 1885f16 (#26153) Co-authored-by: miagilepner <[email protected]> * Known issues: Vault Enterprise - Performance Standby nodes audit log all request headers (#26158) (#26159) * Add known issue docs for Ent Perf Standby audit header logging issue * attempt to improve description Co-authored-by: Peter Wilson <[email protected]> * Correct version for next 1.15 release (#26212) * Update CHANGELOG.md (#26215) To follow new processes for creating release notes on GitHub, I need to update the changelog on the release branch. I've opted to copy the entirety of the 1.15 changelog content to the release branch, adding the notes for 1.15.7. Next I'll create the tag per these instructions https://github.com/hashicorp/engineering-docs/blob/main/consul/releases/release-process.md#manually-create-github-releases-for-ent-only-patch-releases, and update the release notes for that tag & release. * backport of commit 92c5847 (#26234) Co-authored-by: Theron Voran <[email protected]> * backport of commit f1922d2 (#26272) Co-authored-by: Socheat Sok <[email protected]> * UI: Don't show Resultant-ACL banner when wildcard policy present (#26233) (#26271) * Add wildcard calc helpers to permissions service with tests * Check for wildcard access when calculating permissionsBanner * Move resultant-acl banner within TokenExpireWarning so it's mutually exclusive with token expired banner * fix permissions banner if statement * Add margin to resultant-acl * cleanup comments * backport of commit d1fda88 (#26302) Co-authored-by: James Bayer <[email protected]> * backport of commit 02312cb (#26305) Co-authored-by: Victor Rodriguez <[email protected]> * backport of commit c9dafc1 (#26187) Co-authored-by: NikolaiMagicnet <[email protected]> * UI: Replication page navigation fix (#26325) (#26339) * Add replication mirage handler * Add test with skipped failed assertion * Use component-calculated attrsForCurrentMode instead of cluster.replicationAttrs which wasn't triggering component updates * assert previously-skipped assertion * Add changelog * UI: fix replication nav 1.15.x (#26349) * Update test selectors specific to 1.15.x * calculate attrs based on replication-mode service instead of cluster model getter * backport of commit 71758f4 (#26358) Co-authored-by: Ryan Cragun <[email protected]> * UI: Dependency bumps 1.15.x (#26371) * reform yarn.lock without minimatch or qs in resolutions * pin async and nth-check * fix TS errors after bump * bump ember-template-lint and disable broken rules * pin ansi-html * add extra lint rule to skip * remove ember-d3 in favor of specific d3 libraries we import except d3-selection which was failing in compareAttributes * add changelog from PR to main --------- Co-authored-by: akshya96 <[email protected]> Co-authored-by: Scott Miller <[email protected]> Co-authored-by: Peter Wilson <[email protected]> Co-authored-by: miagilepner <[email protected]> Co-authored-by: Meggie <[email protected]> Co-authored-by: Theron Voran <[email protected]> Co-authored-by: Socheat Sok <[email protected]> Co-authored-by: Chelsea Shaw <[email protected]> Co-authored-by: James Bayer <[email protected]> Co-authored-by: Victor Rodriguez <[email protected]> Co-authored-by: NikolaiMagicnet <[email protected]> Co-authored-by: Ryan Cragun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a cluster is the replication primary for both
DRandPerformancetypes, navigating between the pages would not update the page data without a full page refresh. This PR fixes that behavior and adds a test.Before
After
We were relying on a calculated value from the cluster model to update the components, but it wasn't triggering properly. By moving the data to the parent component which uses it, the DOM changes are triggered.