Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of cli: fixed HOME not set error into release/1.16.x #26244

Merged

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #26243 to be assessed for backporting due to the inclusion of the label backport/1.16.x.

The below text is copied from the body of the original PR.


When HCP subcommands were added it created a hard dependency on HOME being configured for users. The upstream HCP lib has been slightly refactored to take a path argument and in the Vault CLI we are just ignoring home directory not set errors.

Fixes #26199.


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/cli-home/naturally-outgoing-terrier branch from b4e95a1 to 85522c6 Compare April 2, 2024 22:24
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 2, 2024
@jasonodonnell jasonodonnell added this to the 1.16.1 milestone Apr 2, 2024
Copy link

github-actions bot commented Apr 2, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Apr 2, 2024

Build Results:
All builds succeeded! ✅

@anwittin anwittin merged commit 8c515f2 into release/1.16.x Apr 2, 2024
76 of 77 checks passed
@anwittin anwittin deleted the backport/cli-home/naturally-outgoing-terrier branch April 2, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants