Allow for path configuration on token helpers #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonodonnell
commented
Apr 2, 2024
Comment on lines
-221
to
-223
| if err != nil { | ||
| return "" | ||
| } |
There was a problem hiding this comment.
This empty return concerned me because we use this value in filepath.Join prior to deleting files.
ccapurso
approved these changes
Apr 2, 2024
divyaac
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up PR for #36 to refactor the code a little bit more to make it more testable. I've added a path configurable and a test to ensure we error out if the client supplies an empty path. If this is merged I will update the Vault CLI code to pass in a path (or ignore it).