Backport Revert "Implement user lockout log (#23140)" 1.13.x #23767
+3
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
davidadeleon
changed the title
|
CI Results: |
This reverts commit 8f70fb9.
ryancragun
force-pushed
the
davidadeleon/revert-backport-1.13.x-implement-user-lockout-log
branch
from
32560b8 to
a947296
Compare
ryancragun
approved these changes
Oct 20, 2023
| @@ -2307,6 +2304,7 @@ func (c *Core) LocalUpdateUserFailedLoginInfo(ctx context.Context, userKey Faile | |||
| // delete the entry from the map, if no key exists it is no-op | |||
| delete(c.userFailedLoginInfo, userKey) | |||
| } | |||
| c.userFailedLoginInfoLock.Unlock() | |||
There was a problem hiding this comment.
Deferring this is probably a good idea, though I understand the whole change was reverted because of a race. Feels like adding this back would still make sense.
|
Build Results: |
ryancragun
deleted the
davidadeleon/revert-backport-1.13.x-implement-user-lockout-log
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8f70fb9.