Implement user lockout log #23140
Merged
Implement user lockout log #23140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
ccapurso
reviewed
Oct 4, 2023
| lockedUserCount := c.getUserFailedLoginCount(ctx) | ||
|
|
||
| if lockedUserCount > 0 { | ||
| c.Logger().Warn("user lockout(s) in effect") |
There was a problem hiding this comment.
Would it make sense to note that users can access who is locked out via the sys/locked-users endpoint?
ccapurso
approved these changes
Oct 5, 2023
davidadeleon
added a commit
that referenced
this pull request
Oct 9, 2023
* implement user lockout logger * formatting * make user lockout log interval configurable * create func to get locked user count, and fix potential deadlock * fix test * fix test * add changelog
davidadeleon
added a commit
that referenced
this pull request
Oct 9, 2023
* implement user lockout logger * formatting * make user lockout log interval configurable * create func to get locked user count, and fix potential deadlock * fix test * fix test * add changelog Co-authored-by: davidadeleon <[email protected]>
This was referenced Oct 10, 2023
davidadeleon
added a commit
that referenced
this pull request
Oct 12, 2023
* implement user lockout logger * formatting * make user lockout log interval configurable * create func to get locked user count, and fix potential deadlock * fix test * fix test * add changelog
davidadeleon
added a commit
that referenced
this pull request
Oct 19, 2023
This reverts commit 92fcfda.
davidadeleon
added a commit
that referenced
this pull request
Oct 20, 2023
ryancragun
pushed a commit
that referenced
this pull request
Oct 20, 2023
This reverts commit 8f70fb9.
ryancragun
pushed a commit
that referenced
this pull request
Oct 20, 2023
ryancragun
pushed a commit
that referenced
this pull request
Oct 20, 2023
ryancragun
pushed a commit
that referenced
this pull request
Oct 25, 2023
This reverts commit 92fcfda. Co-authored-by: davidadeleon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a log which will be emitted at a configurable interval (default of 1 minute), in the event of there being a locked user anywhere in Vault. This adds visibility for operators around the user lockout feature via the operational logs, allowing them to know when a user lockout is in effect. A WARN log will be emitted when a lockout is in effect, and an INFO log will be emitted when all lockouts have been cleared. The log interval can be modified as part of the server config using the
user_lockout_log_intervalparameter.Example Config:
user_lockout_log_interval="30s"