Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude changelog in verifying doc/ui #23601

Merged
merged 3 commits into from
Oct 11, 2023
Merged

exclude changelog in verifying doc/ui #23601

merged 3 commits into from
Oct 11, 2023

Conversation

hghaf099
Copy link
Contributor

@hghaf099 hghaf099 commented Oct 11, 2023

Go tests should not run for a UI PR which also contains changelog.

@hghaf099 hghaf099 requested a review from a team as a code owner October 11, 2023 14:35
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 11, 2023
@hghaf099 hghaf099 changed the title exclude changelog in verify doc/ui exclude changelog in verifying doc/ui Oct 11, 2023
@hghaf099 hghaf099 requested a review from Monkeychip October 11, 2023 14:49
@github-actions
Copy link

github-actions bot commented Oct 11, 2023

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

@hghaf099 hghaf099 merged commit 163c03f into main Oct 11, 2023
116 checks passed
@hghaf099 hghaf099 deleted the ci-verify-changes-fix branch October 11, 2023 15:18
marcboudreau pushed a commit that referenced this pull request Oct 11, 2023
…guration (#23547)

* CI: Pre-emptively delete logs dir after cache restore in test-collect-reports (#23600)

* Fix OktaNumberChallenge (#23565)

* remove arg

* changelog

* exclude changelog in verifying doc/ui PRs (#23601)

* Audit: eventlogger sink node reopen on SIGHUP (#23598)

* ensure nodes are asked to reload audit files on SIGHUP

* added changelog

* Capture errors emitted from all nodes during proccessing of audit pipelines (#23582)

* Update security-scan.yml

* Listeners: Redaction only for TCP (#23592)

* redaction should only work for TCP listeners, also fix bug that allowed custom response headers for unix listeners

* fix failing test

* updates from PR feedback

* fix panic when unlocking unlocked user (#23611)

* VAULT-18307: update rotation period for aws static roles on update (#23528)

* add disable_replication_status_endpoints tcp listener config parameter

* add wrapping handler for disabled replication status endpoints setting

* adapt disable_replication_status_endpoints configuration parsing code to refactored parsing code

* refactor configuration parsing code to facilitate testing

* fix a panic when parsing configuration

* update refactored configuration parsing code

* fix merge corruption

* add changelog file

* document new TCP listener configuration parameter

* make sure disable_replication_status_endpoints only has effect on TCP listeners

* use active voice for explanation of disable_replication_status_endpoints

* fix minor merge issue

---------

Co-authored-by: Kuba Wieczorek <[email protected]>
Co-authored-by: Angel Garbarino <[email protected]>
Co-authored-by: Hamid Ghaf <[email protected]>
Co-authored-by: Peter Wilson <[email protected]>
Co-authored-by: Mark Collao <[email protected]>
Co-authored-by: davidadeleon <[email protected]>
Co-authored-by: kpcraig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants