Audit: eventlogger sink node reopen on SIGHUP #23598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteski22
added
core/audit
hashicorp-contributed-pr
|
CI Results: |
…vault into peteski22/audit-sighup-reload
marcboudreau
approved these changes
Oct 11, 2023
|
Build Results: |
|
|
marcboudreau
pushed a commit
that referenced
this pull request
Oct 11, 2023
…guration (#23547) * CI: Pre-emptively delete logs dir after cache restore in test-collect-reports (#23600) * Fix OktaNumberChallenge (#23565) * remove arg * changelog * exclude changelog in verifying doc/ui PRs (#23601) * Audit: eventlogger sink node reopen on SIGHUP (#23598) * ensure nodes are asked to reload audit files on SIGHUP * added changelog * Capture errors emitted from all nodes during proccessing of audit pipelines (#23582) * Update security-scan.yml * Listeners: Redaction only for TCP (#23592) * redaction should only work for TCP listeners, also fix bug that allowed custom response headers for unix listeners * fix failing test * updates from PR feedback * fix panic when unlocking unlocked user (#23611) * VAULT-18307: update rotation period for aws static roles on update (#23528) * add disable_replication_status_endpoints tcp listener config parameter * add wrapping handler for disabled replication status endpoints setting * adapt disable_replication_status_endpoints configuration parsing code to refactored parsing code * refactor configuration parsing code to facilitate testing * fix a panic when parsing configuration * update refactored configuration parsing code * fix merge corruption * add changelog file * document new TCP listener configuration parameter * make sure disable_replication_status_endpoints only has effect on TCP listeners * use active voice for explanation of disable_replication_status_endpoints * fix minor merge issue --------- Co-authored-by: Kuba Wieczorek <[email protected]> Co-authored-by: Angel Garbarino <[email protected]> Co-authored-by: Hamid Ghaf <[email protected]> Co-authored-by: Peter Wilson <[email protected]> Co-authored-by: Mark Collao <[email protected]> Co-authored-by: davidadeleon <[email protected]> Co-authored-by: kpcraig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Vault receives
SIGHUPit iterates a maintained set of reload functions which have responsibility to perform the relevant re-parsing/reconfiguration/reopening of files/Vault/etc.This PR ensures that if an eventlogger sink node (file, syslog, socket) exists within a given audit backend, then it is asked to reopen, rather than interacting with the older (deprecated) way of handling files.
Issue reference: #23596
Note: this PR is currently in draft pending further investigations, but it looks likely this is a bug.