Backport of [VAULT-20630] CI: Use 'ref' (not 'base_ref') as a default git reference to check out code in the test-go GHA workflow into release/1.13.x #23459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
hc-github-team-secure-vault-core
force-pushed
the
backport/kubawi/VAULT-20630/dont-use-base-ref-as-a-default-for-go-tests/largely-first-bream
branch
from
f2203b8 to
d34cbbe
Compare
|
|
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
…ce to check out code in the test-go GHA workflow (#23458)
kubawi
force-pushed
the
backport/kubawi/VAULT-20630/dont-use-base-ref-as-a-default-for-go-tests/largely-first-bream
branch
from
f149f39 to
213c446
Compare
kubawi
approved these changes
Oct 3, 2023
kubawi
deleted the
backport/kubawi/VAULT-20630/dont-use-base-ref-as-a-default-for-go-tests/largely-first-bream
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #23458 to be assessed for backporting due to the inclusion of the label backport/1.13.x.
🚨
The person who merged in the original PR is:
@kubawi
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
A companion PR to #23453.
This one changes the default value of the
checkout-refinput in the test-go.yml workflow (fromgithub.base_reftogithub.ref). Currently, nothing (that I am aware of) uses that default, but it could bite us in the future.Overview of commits