[VAULT-20630] CI: Use 'ref' (not 'base_ref') as a default git reference to check out code in the test-go GHA workflow #23458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce to check out code in the test-go GHA workflow
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
github-actions
bot
added
the
hashicorp-contributed-pr
hghaf099
approved these changes
Oct 3, 2023
|
Build Results: |
|
CI Results: |
kubawi
deleted the
kubawi/VAULT-20630/dont-use-base-ref-as-a-default-for-go-tests
branch
kubawi
added a commit
that referenced
this pull request
Oct 3, 2023
…ce to check out code in the test-go GHA workflow (#23458)
kubawi
added a commit
that referenced
this pull request
Oct 3, 2023
…ce to check out code in the test-go GHA workflow (#23458)
kubawi
added a commit
that referenced
this pull request
Oct 3, 2023
…ce to check out code in the test-go GHA workflow (#23458) (#23459) Co-authored-by: Kuba Wieczorek <[email protected]>
kubawi
added a commit
that referenced
this pull request
Oct 3, 2023
…ce to check out code in the test-go GHA workflow (#23458) (#23469) Co-authored-by: Kuba Wieczorek <[email protected]>
hellobontempo
pushed a commit
that referenced
this pull request
Oct 3, 2023
…ce to check out code in the test-go GHA workflow (#23458)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A companion PR to #23453.
This one changes the default value of the
checkout-refinput in the test-go.yml workflow (fromgithub.base_reftogithub.ref). Currently, nothing (that I am aware of) uses that default, but it could bite us in the future.