UI: Part 4 - hds adoption replace <Modal> #23451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
github-actions
bot
added
the
hashicorp-contributed-pr
hellobontempo
commented
Oct 2, 2023
| @@ -91,12 +91,6 @@ | |||
| color: $red-500; | |||
| } | |||
|
|
|||
| &.is-warning-outlined { | |||
There was a problem hiding this comment.
Removing because this color doesn't exist in HDS buttons
hellobontempo
commented
Oct 2, 2023
| @@ -170,3 +170,10 @@ form { | |||
| label { | |||
| cursor: pointer; | |||
| } | |||
|
|
|||
| // HDS modifications | |||
| .hds-modal { | |||
There was a problem hiding this comment.
I wasn't sure where to put this - if there are more I may create a separate file, but it seemed okay here for now
hellobontempo
commented
Oct 2, 2023
| <KvDeleteModal @mode="delete-metadata" @metadata={{@metadata}} @onDelete={{this.onDelete}}> | ||
| Permanently delete | ||
| </KvDeleteModal> | ||
| <KvDeleteModal |
|
Build Results: |
hellobontempo
commented
Oct 3, 2023
| > | ||
| Delete | ||
| </KvDeleteModal> | ||
| /> |
kiannaquach
reviewed
Oct 3, 2023
| @onClose={{fn (mut this.showRotatePrompt) false}} | ||
| > | ||
| <section class="modal-card-body"> | ||
| <Hds::Modal id="ldap-rotate-password-modal" @onClose={{fn (mut this.showRotatePrompt) false}} as |M|> |
There was a problem hiding this comment.
Just out of curiousity - do modals always need id's now?
There was a problem hiding this comment.
Not that I can tell - but I wondered if screen readers used them. I also thought that we could use them in a general test selector .hds-modal#${id}
There was a problem hiding this comment.
Thanks for clarifying, Claire! I think it's a great pattern to add the ids to each modal :)
kiannaquach
reviewed
Oct 3, 2023
| > | ||
| <section class="modal-card-body"> | ||
| <M.Header @icon="trash"> |
There was a problem hiding this comment.
Is every header going to be a trash icon or should we add an icon key to the modalDisplay object in the component?
There was a problem hiding this comment.
These are all delete related, so they'll all have the trash!
hellobontempo
merged commit f909b49
into
ui/VAULT-17315-hds-adoption-replace-Modal
54 of 61 checks passed
hellobontempo
added a commit
that referenced
this pull request
Oct 6, 2023
* UI: Part 1 - hds adoption replace <Modal> (#23363) * replace policy-form modal * replace clients/attribution modal * clients/config modal * scope form odal * remove button type * include toolbar to match other example templates * rotate credentials modal * add toolbar button class for hds buttons * transformation-edit modal * add back test selector * add route arg to button! * update link status * fix link-status tests * remove prevent default * update db tests * update tests * use page alert for hcp link status banner * fix scopy button selector * fix sidebar test * change to neutral banner * UI: Part 2 - hds adoption replace <Modal> (#23398) * upgrade HDS library (adds support for snippet containers * cleanup flight icons * replace transit key action modals * re-add deps as devDeps * remove line * address transit tests * UI: Part 3 - hds adoption replace <Modal> (#23415) * cleanup css * cleanup extra type attr * masked input download modal * use Hds::Button in download button" * fix size of modal * tiny icon fix * refactor download button to always render download icon * update tests * UI: Part 3.5 - hds adoption replace <Modal> (#23448) * replication-promote modal * replication component modals * replication add secondary modal * move update text for diff * UI: Part 4 - hds adoption replace <Modal> (#23451) * k8 configure modal * kv delete modal * ldap modals * pki modals * add trash icon * move deps * UI: Part 5 - hds adoption replace <Modal> (#23471) * replace confirmation modals --------- * UI: Part 6 - hds adoption replace <Modal> (#23484) * search select with modal * policy search select modal * replace date dropdown for client dashboard * change padding to top * update policy example args * lolllll test typo wow * update dropdown tests * shamir flow modals! * add one more container * update test selectors * UI: Final hds adoption replace <Modal> cleanup PR (#23522) * search select with modal * policy search select modal * replace date dropdown for client dashboard * change padding to top * update policy example args * lolllll test typo wow * update dropdown tests * shamir flow modals! * add one more container * update test selectors * remove wormhole and modal component * fix selectors * uninstall wormhole * remove shamir-modal-flow class * fix confirm modal test * fix pki and kv test * fix toolbar selector kv * client and download button test * fix-confirmation-modal-padding * fix replication modal tests so relevant modal opens (#23540) * more confirmation modal tests * adds changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces modals in ember engines