UI: HDS adoption replace <Modal> #23382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* replace policy-form modal * replace clients/attribution modal * clients/config modal * scope form odal * remove button type * include toolbar to match other example templates * rotate credentials modal * add toolbar button class for hds buttons * transformation-edit modal * add back test selector * add route arg to button! * update link status * fix link-status tests * remove prevent default * update db tests * update tests * use page alert for hcp link status banner * fix scopy button selector * fix sidebar test * change to neutral banner
github-actions
bot
added
the
hashicorp-contributed-pr
* upgrade HDS library (adds support for snippet containers * cleanup flight icons * replace transit key action modals * re-add deps as devDeps * remove line * address transit tests
* cleanup css * cleanup extra type attr * masked input download modal * use Hds::Button in download button" * fix size of modal * tiny icon fix * refactor download button to always render download icon * update tests
* replication-promote modal * replication component modals * replication add secondary modal * move update text for diff
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
* k8 configure modal * kv delete modal * ldap modals * pki modals * add trash icon
* replace confirmation modals ---------
* search select with modal * policy search select modal * replace date dropdown for client dashboard * change padding to top * update policy example args * lolllll test typo wow * update dropdown tests * shamir flow modals! * add one more container * update test selectors
* search select with modal * policy search select modal * replace date dropdown for client dashboard * change padding to top * update policy example args * lolllll test typo wow * update dropdown tests * shamir flow modals! * add one more container * update test selectors * remove wormhole and modal component * fix selectors * uninstall wormhole * remove shamir-modal-flow class * fix confirm modal test * fix pki and kv test * fix toolbar selector kv * client and download button test * fix-confirmation-modal-padding * fix replication modal tests so relevant modal opens (#23540) * more confirmation modal tests
|
Build Results: |
|
CI Results: |
kiannaquach
reviewed
Oct 6, 2023
| font-weight: $font-weight-semibold; | ||
| box-shadow: $box-shadow-low; | ||
| border-radius: $radius; | ||
| font-weight: $font-weight-semibold; // TODO delete |
There was a problem hiding this comment.
just out of curiosity - what's the default font-weight for the copy button?
There was a problem hiding this comment.
There's no override option, it's only ever the clipboard icon 😄 [docs]
There was a problem hiding this comment.
If you consult the docs - the font weights for buttons appear to be -token-typography-font-weight-regular: 400;
kiannaquach
reviewed
Oct 6, 2023
| @@ -166,7 +165,6 @@ | |||
| "ember-test-selectors": "6.0.0", | |||
| "ember-tether": "^2.0.1", | |||
| "ember-truth-helpers": "3.0.0", | |||
| "ember-wormhole": "0.6.0", | |||
zofskeez
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Side branch for adopting
<Hds::Modal><button>components inside modals with<Hds::Button><Hds::Button>is now used in<DownloadButton><button>components are replaced to make way for fully adopting<Hds::Button>@containerto<Hds::Copy::Button>components that render inside modals (which are otherwise not functional)#23363
#23398
#23415
#23451
#23471
#23484
#23522