Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of UI: [VAULT-19982] confirm delete modal for namespaces into release/1.14.x #23100

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #23066 to be assessed for backporting due to the inclusion of the label backport/1.14.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@kiannaquach
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description
Setting a height using inline styles directly in the template causes Content Security Policy errors.

Content Security Policy errors from putting inline styles:
Screenshot 2023-09-13 at 4 31 38 PM

The bug:
Screenshot 2023-09-13 at 2 57 14 PM

A few solutions to possibly prevent the Content Security Policy error:
Solution 1:
Instead of calculating the height, set a fixed min-height and add class with that min-height style. See possible solution 1 here: f5b785e
Solution 2:
Add the height style directly using js instead of in our templates. I paired with Jordan a little bit on this and found that this will likely not cause Content Security Policy errors since ember-basic-dropdown does something similar and injects some styling and these styles are set after initial render. See possible solution 2 here: 5fa9b68


Overview of commits

@hashicorp-cla
Copy link

hashicorp-cla commented Sep 14, 2023

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


1 out of 2 committers have signed the CLA.

  • kiannaquach
  • temp

temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 14, 2023
@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

@kiannaquach kiannaquach added this to the 1.14.4 milestone Sep 14, 2023
@kiannaquach kiannaquach marked this pull request as ready for review September 14, 2023 19:57
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@schavis schavis added the vault-update Used by SPE team to filter out PRs not related to content label Sep 15, 2023
@zofskeez zofskeez closed this Sep 22, 2023
@zofskeez zofskeez deleted the backport/ui/confirm-bug/formerly-winning-treefrog branch September 22, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed vault-update Used by SPE team to filter out PRs not related to content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants