-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: [VAULT-19982] confirm delete modal for namespaces #23066
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
label
Sep 13, 2023
kiannaquach
changed the title
Possible soln 1: add a class w/ min height instead of calculated height
UI: [VAULT-19982] confirm delete modal for namespaces
Sep 13, 2023
kiannaquach
added
backport/1.14.x
bug
Used to indicate a potential bug
pr/no-changelog
labels
Sep 14, 2023
zofskeez
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Build Results: |
CI Results: |
This was referenced Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Used to indicate a potential bug
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting a height using inline styles directly in the template causes Content Security Policy errors.
Content Security Policy errors from putting inline styles:
The bug:
A few solutions to possibly prevent the Content Security Policy error:
Solution 1:
Instead of calculating the height, set a fixed
min-height
and addclass
with that min-height style. See possible solution 1 here: f5b785eSolution 2:
Add the height style directly using js instead of in our templates. I paired with Jordan a little bit on this and found that this will likely not cause Content Security Policy errors since
ember-basic-dropdown
does something similar and injects some styling and these styles are set after initial render. See possible solution 2 here: 5fa9b68