Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: [VAULT-17035 VAULT-17038 VAULT-17039] Dashboard Quick Actions card #21929
UI: [VAULT-17035 VAULT-17038 VAULT-17039] Dashboard Quick Actions card #21929
Changes from 17 commits
3548b9d
49c8444
79815f6
70ac4df
7ae1a21
7f24e84
1e2670b
8044dd3
74ab401
e37fd7b
c6c8538
fea5a6f
ea759c1
b26989b
04d06f9
2c6cbf2
2fd9e1d
1f704e1
f3ceb8e
b650599
3a51f82
e93c243
2f0a734
c666969
eb88387
2c5bf06
49154fb
426176c
842deea
159e917
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it was in the design, but I don't feel like you should have ellipsis at the end of "Type to find a role". Ellipsis indicate an omission of words, which I don't feel like we have here. The placeholder for Certificate serial number makes sense to have an ellipsis but I would say it's complete as "Type to find a role"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment here about ellipsis. If it's on the designs, I feel like it's worth clarifying with them if it makes sense in the cases I'm pointing out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense to me! I'll remove the ellipsis for now, and ask design about it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that the PKI overview card SearchSelect placeholders use ellipsis, I will still remove for now and will clarify w/ design @Monkeychip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - I was under the impression that ellipses were our pattern for search select place holders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice and clean on this. Looks great!