UI: [VAULT-17035 VAULT-17038 VAULT-17039] Dashboard Quick Actions card #21929
Conversation
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: All Go tests passed! ✅ |
|
Build Results: |
kiannaquach
changed the title
| case 'Issue certificate': | ||
| return { | ||
| title: 'Role to use', | ||
| placeholder: 'Type to find a role...', |
There was a problem hiding this comment.
Not sure if it was in the design, but I don't feel like you should have ellipsis at the end of "Type to find a role". Ellipsis indicate an omission of words, which I don't feel like we have here. The placeholder for Certificate serial number makes sense to have an ellipsis but I would say it's complete as "Type to find a role"
| @disallowNewItems={{true}} | ||
| @fallbackComponent="input-search" | ||
| @onChange={{this.handleSearchEngineSelect}} | ||
| @placeholder="Type to select a mount..." |
There was a problem hiding this comment.
same comment here about ellipsis. If it's on the designs, I feel like it's worth clarifying with them if it makes sense in the cases I'm pointing out.
There was a problem hiding this comment.
That makes sense to me! I'll remove the ellipsis for now, and ask design about it!
There was a problem hiding this comment.
I just realized that the PKI overview card SearchSelect placeholders use ellipsis, I will still remove for now and will clarify w/ design @Monkeychip
There was a problem hiding this comment.
Yeah - I was under the impression that ellipses were our pattern for search select place holders
| @onChange={{this.handleActionSelect}} | ||
| @fallbackComponent="input-search" | ||
| @nameKey={{this.searchSelectParams.nameKey}} | ||
| @disabled={{not this.searchSelectParams.model}} |
There was a problem hiding this comment.
nice and clean on this. Looks great!
Quick Actions Card
TODOs: